Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 压缩过程忽略 .sock 套接字 #2706

Merged
merged 1 commit into from
Oct 27, 2023
Merged

fix: 压缩过程忽略 .sock 套接字 #2706

merged 1 commit into from
Oct 27, 2023

Conversation

ssongliu
Copy link
Contributor

Refs #2702

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Oct 27, 2023

@ssongliu: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@1Panel-bot 1Panel-bot added the dev label Oct 27, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

zhengkunwang223
zhengkunwang223 reviewed Oct 27, 2023
View reviewed changes
Copy link
Contributor

@zhengkunwang223 zhengkunwang223 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm label Oct 27, 2023
@ssongliu
Copy link
Contributor Author

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Oct 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ssongliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit abedc72 into dev Oct 27, 2023
6 checks passed
@f2c-ci-robot f2c-ci-robot bot deleted the pr@dev@fix_system branch October 27, 2023 07:05
Ausli
Ausli reviewed Feb 28, 2024
View reviewed changes
Copy link

@Ausli Ausli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这样判断存在隐患，如果套接字不是以.sock结尾的将无法忽略
There are pitfalls to this judgment, as sockets that do not end in .sock will not be ignored.

@Ausli Ausli mentioned this pull request Mar 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ausli Ausli Ausli left review comments

@zhengkunwang223 zhengkunwang223 zhengkunwang223 left review comments

@wangdan-fit2cloud wangdan-fit2cloud Awaiting requested review from wangdan-fit2cloud

Assignees

@zhengkunwang223 zhengkunwang223

Labels
approved dev do-not-merge/release-note-label-needed lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ssongliu @zhengkunwang223 @Ausli @1Panel-bot