feat(system): Fix Issue Allowing Access via Old Secure Entry After Mo… #7659
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| entrance = authService.GetSecurityEntrance() | ||
| if entrance == "" { | ||
| currentEntrance := authService.GetSecurityEntrance() | ||
| if currentEntrance == "" || currentEntrance != entrance { | ||
| handleNoRoute(c) | ||
| return | ||
| } |
There was a problem hiding this comment.
There is no issue with the code itself; it appears to be checking if the entrance parameter has changed since authentication. If so, it triggers a "no route" handling function using handleNoRoute. The current logic correctly ensures that changes in entrance trigger an error response when they occur after the initial check during authentication.
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wanghe-fit2cloud The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Refs #7658