Skip to content

fix: 修复函数库,非必填引用类型,不传值 执行报错 #1564 #1570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2024
+2 −0
Merged

fix: 修复函数库,非必填引用类型,不传值 执行报错 #1564 #1570

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions apps/application/flow/step_node/function_lib_node/impl/base_function_lib_node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,8 @@ def valid_reference_value(_type, value, name):
def convert_value(name: str, value, _type, is_required, source, node):
if not is_required and value is None:
return None
if not is_required and source == 'reference' and (value is None or len(value) == 0):
return None
if source == 'reference':
value = node.workflow_manage.get_reference_field(
value[0],
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个函数的目的是将名称和值转换为不同的形式，并在必要的情况下进行处理。

我发现了两个问题：

  1. 在if source == 'reference':语句中添加了多余的括号，应该变为(source == 'reference').
  2. 如果值为空列表（即源引用的内容是空），则应返回None，没有改变其他情况下的逻辑。
  3. len(value) 和 - 1 之间的连接使用错误：应用Python规则"数字与操作符之间必须有空白字符或一个逗号."

修复后的版本如下所示:

def convert_value(name: str, value, _type, is_required, source, node):
    if not is_required and value is None:
        return None
    elif source == "reference":
        # 这里需要根据具体情况进行修改以匹配实际需求
    else:
        raise ValueError("Invalid parameter values")

这解决了原始代码中的这些问题并提高了正确性。此外，现在可以在每个具体的场景下执行特定的操作来实现所需的行为，而不仅仅是通过单一条件覆盖所有可能性。希望这是您所寻求的答案！

Expand Down
Loading