Skip to content

fix: 修复工作流节点收缩后无法发布 #1582 #1626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

shaohuzhang1
Copy link
Contributor

fix: 修复工作流节点收缩后无法发布 #1582

Copy link

f2c-ci-robot bot commented Nov 14, 2024

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

f2c-ci-robot bot commented Nov 14, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shaohuzhang1 shaohuzhang1 merged commit 8cf23fe into main Nov 14, 2024
3 of 4 checks passed
@shaohuzhang1 shaohuzhang1 deleted the pr@main@fix_workflow_publish branch November 14, 2024 02:04
@@ -51,7 +51,7 @@
</div>
</div>
<el-collapse-transition>
<div @mousedown.stop @keydown.stop @click.stop v-if="showNode" class="mt-16">
<div @mousedown.stop @keydown.stop @click.stop v-show="showNode" class="mt-16">
<el-alert
v-if="node_status != 200"
class="mb-16"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个代码中有一些潜在问题和需要改进的地方:

  1. 没有正确地使用v-model, v-on应该用到类组件(Vue3 版本)而不是普通方法。

  2. .mousedown.stop, .keydown.stop, 和 .click.stop事件上应用了@mousedown.stop @keydown.stop @click.stop, 这些是 Vue 的原生监听器,而不需要额外的指令。正确的写法应该是使用 nativeListener:

<nativeListener />

这样可以更易于在不同环境中使用,例如本地开发环境或生产运行时环境。
此外,代码中有重复的部分,请尽量避免。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants