feat: AI dialog box, left mouse button menu #2005
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| <template> | ||
| <div> | ||
| <vue3-menus v-model:open="isOpen" :event="eventVal" :menus="menus" hasIcon> | ||
| <template #icon="{ menu }" | ||
| ><AppIcon v-if="menu.icon" :iconName="menu.icon"></AppIcon | ||
| ></template> | ||
| <template #label="{ menu }"> {{ menu.label }}</template> | ||
| </vue3-menus> | ||
| </div> | ||
| </template> | ||
| <script setup lang="ts"> | ||
| import { Vue3Menus } from 'vue3-menus' | ||
| import { MsgSuccess } from '@/utils/message' | ||
| import AppIcon from '@/components/icons/AppIcon.vue' | ||
| import bus from '@/bus' | ||
| import { ref, nextTick, onMounted } from 'vue' | ||
| const isOpen = ref<boolean>(false) | ||
| const eventVal = ref({}) | ||
| function getSelection() { | ||
| const selection = window.getSelection() | ||
| if (selection && selection.anchorNode == null) { | ||
| return null | ||
| } | ||
| const text = selection?.anchorNode?.textContent | ||
| return text && text.substring(selection.anchorOffset, selection.focusOffset) | ||
| } | ||
| /** | ||
| * 打开控制台 | ||
| * @param event | ||
| */ | ||
| const openControl = (event: any) => { | ||
| const c = getSelection() | ||
| isOpen.value = false | ||
| if (c) { | ||
| nextTick(() => { | ||
| eventVal.value = event | ||
| isOpen.value = true | ||
| }) | ||
| event.preventDefault() | ||
| } | ||
| } | ||
|
|
||
| const menus = ref([ | ||
| { | ||
| label: '复制', | ||
| icon: 'app-copy', | ||
| click: () => { | ||
| const selectionText = getSelection() | ||
| if (selectionText) { | ||
| clearSelectedText() | ||
| navigator.clipboard.writeText(selectionText).then(() => { | ||
| MsgSuccess('复制成功') | ||
| }) | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| label: '引用', | ||
| icon: 'app-quote', | ||
| click: () => { | ||
| bus.emit('chat-input', getSelection()) | ||
| clearSelectedText() | ||
| } | ||
| } | ||
| ]) | ||
| /** | ||
| * 清除选中文本 | ||
| */ | ||
| const clearSelectedText = () => { | ||
| if (window.getSelection) { | ||
| var selection = window.getSelection() | ||
| if (selection) { | ||
| selection.removeAllRanges() | ||
| } | ||
| } | ||
| } | ||
| onMounted(() => { | ||
| bus.on('open-control', openControl) | ||
| }) | ||
| </script> | ||
| <style lang="scss"></style> | ||
|
There was a problem hiding this comment. The code looks mostly clean and well-structured, but there are a few things that could be improved:
Here's the revised version with these improvements: @@ -0,0 +1,86 @@
+<template>
+ <div>
+ <vue3-menus v-model:open="isOpen" :event="evenVal" :menus="menus" has-icon> <!-- Changed ':event' to 'v-on:event=' -->
+ <template #icon="{ menu }">
+ <AppIcon v-if="menu.icon" :icon-name="menu.icon"></AppIcon>
+ </template>
+ <template #label="{ menu }">{{ menu.label }}</template>
+ </vue3-menus>
+ </div>
+</template>
+
<script setup lang="ts">
+import { ref, watchEffect, onMounted } from 'vue';
+import Vue3Menus from 'vue3-menus';
+import { MsgSuccess } from '@/utils/message';
+import AppIcon from '@/components/icons/AppIcon.vue';
+import bus from '@/bus';
interface MenuItem {
label: string;
icon?: string;
click?(): void;
}
const isOpen = ref(false);
const evenVal = ref({}); // Corrected ':event' to 'v-on:event='
function getSelection() {
const selection = window.getSelection();
if (!selection || !selection.anchorNode) {
return null;
}
const text = selection.ancherNode.textContent;
return text && text.substring(selection.anchor_offset, selection.focus_offset);
}
/**
* 打开控制台
* @param event
*/
const openControl = async (event: any) => {
const c = getSelection();
isOpen.value = false;
if (c) {
try {
await nextTick(); // Wait until DOM is updated
evenVal.value = event;
isOpen.value = true;
} catch (error) {
console.error('Error opening control:', error);
}
event.preventDefault();
}
};
watchEffect(() => {
if (window.navigator.clipboard && window.navigator.permissions) {
bus.on(
'open-control',
(evt: Event, selectionText: string | null, clipboardSupported: boolean) => {
if (clipboardSupported && selectionText !== null) {
clearSelectedText();
window.navigator.clipboard.writeText(selectionText).then(
() => {
MsgSuccess('复制成功');
},
(err) => {
console.error('Error copying:', err);
}
);
}
}
);
} else {
bus.off('open-control');
}
});
function clearSelectedText() {
if (document.getSelection) {
let selection = document.getSelection();
if (selection && selection.type === 'Range') {
selection.removeAllRanges();
}
}
}
onMounted(async () => {
const clipboardSupported = await window.navigator.permissions.query({ name: "clipboard-write" }).catch(console.log);
const initialDataForBus = clipboardSupported.state === "granted"
? [null, "", clipboardSupported]
: [];
bus.emit("initial-data", ...initialDataForBus); // Emit appropriate data based on permission state
});
</script>
<style scoped></style>Key Changes Made:
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The provided code snippet seems to be related to an interactive component that displays information about an application and provides a way for users to interact with it (by clicking on the card).
Potential Issues and Optimization Suggestions:
Event Handling:
@stopdirective applied to the.contentdiv, which prevents any further event propagation up to parent elements. This can make sure that clicks within this element don't trigger unnecessary actions outside of its boundary.Optimization:
computed()is generally not recommended because it means the function is recreated whenever anything changes around it. You might consider using an arrow function instead if you want the function to have access to thethiscontext defined in another scope.Code Duplication:
add_answer_text_list()function duplicates some logic from withinanswer_text_list(). Consider merging these functions or extracting common functionality into separate utility methods.Here's the cleaned-up code:
Explanation:
chatMessageandhandleCardClick.This version maintains readability while improving performance by minimizing redundant code execution.