Skip to content

feat: audio support m4a #2277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2025
Merged

feat: audio support m4a #2277

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui/src/components/ai-chat/component/chat-input-operate/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ const localLoading = computed({
const imageExtensions = ['jpg', 'jpeg', 'png', 'gif', 'bmp']
const documentExtensions = ['pdf', 'docx', 'txt', 'xls', 'xlsx', 'md', 'html', 'csv']
const videoExtensions = ['mp4', 'avi', 'mov', 'mkv', 'flv']
const audioExtensions = ['mp3', 'wav', 'ogg', 'aac']
const audioExtensions = ['mp3', 'wav', 'ogg', 'aac', 'm4a']

const getAcceptList = () => {
const { image, document, audio, video } = props.applicationDetails.file_upload_setting
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no significant issues with the current code, but here is a minor suggestion:

  1. Remove Trailing Commas: The trailing comma after props.applicationDetails.file_upload_setting could be removed to make the syntax more concise.

Revised Code:

@@ -260,7 +260,7 @@
 const localLoading = computed({
 const imageExtensions=['jpg','jpeg','png','gif','bmp']
 const documentExtensions=['pdf','docx','txt','xls','xlsx','md','html','csv']
 const videoExtensions =['mp4','avi','mov','mkv','flv']
-const audioExtensions=['mp3','wav','ogg','aac']
+const audioExtensions=['mp3','wav','ogg','aac','m4a']

 const getAcceptList = () => {
   const {image , document, audio, video} = props.applicationDetails.file_upload_setting

This change makes the syntax cleaner and less error-prone.

Expand Down