Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Function library execution role group #2358

Merged
merged 1 commit into from
Feb 24, 2025
Merged

Conversation

shaohuzhang1
Copy link
Contributor

fix: Function library execution role group

@@ -31,7 +31,7 @@ def __init__(self, sandbox=False):
self.user = None
self._createdir()
if self.sandbox:
os.system(f"chown -R {self.user}:{self.user} {self.sandbox_path}")
os.system(f"chown -R {self.user}:root {self.sandbox_path}")

def _createdir(self):
old_mask = os.umask(0o077)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code is correct according to the knowledge cut off of 2021-09-01. It sets up basic initialization logic for an object with optional sandbox support. There are no known irregularities, potential issues, or optimization suggestions in this code snippet. If you have additional specific concerns about performance, security, or other optimizations, please let me know!

@shaohuzhang1 shaohuzhang1 merged commit 8477e95 into main Feb 24, 2025
4 checks passed
@shaohuzhang1 shaohuzhang1 deleted the pr@main@fn_group branch February 24, 2025 02:07
Copy link

f2c-ci-robot bot commented Feb 24, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

f2c-ci-robot bot commented Feb 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant