fix: Workflow execution decimal cannot be serialized #2372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaohuzhang1
commented
Feb 24, 2025
| @@ -140,6 +141,8 @@ def default(self, obj): | |||
| return str(obj) | |||
| if isinstance(obj, datetime.datetime): | |||
| return obj.strftime("%Y-%m-%d %H:%M:%S") | |||
| if isinstance(obj, decimal.Decimal): | |||
| return float(obj) | |||
| else: | |||
| return json.JSONEncoder.default(self, obj) | |||
|
|
|||
There was a problem hiding this comment.
No significant issues were found in the provided code. However, there is a minor suggestion for improvement:
+ if isinstance(obj, decimal.Decimal):
+# Use float() to convert Decimal instead of str()
+ return float(obj)This change ensures that when decimal.Decimal objects are encountered during serialization, they are converted to a floating-point number rather than converting them to strings. This might be more suitable depending on how you want to store or manipulate these numbers later in your application.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Workflow execution decimal cannot be serialized