refactor: Cancel last autoplay audio #2431
Conversation
--story=1017953 --user=刘瑞斌 【优化】多轮对话，语音识别自动播放，会重叠播放 https://www.tapd.cn/57709429/s/1660001
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| pausePlayAnswerText() | ||
| // console.log(1234) | ||
| }) | ||
| bus.emit('pause-autoplay') | ||
| // 第一次回答后自动播放， 打开历史记录不自动播放 | ||
| if (props.tts && props.tts_autoplay && buttonData.value.write_ed && !buttonData.value.update_time) { | ||
| playAnswerText(buttonData.value.answer_text) |
There was a problem hiding this comment.
There are no irregularities in the provided code, but there is one potential issue related to the handling of onMounted:
if (props.tts && props.tts_autoplay && buttonData.value.write_ed && !buttonData.value.update_time) {This line checks conditions that might lead to unexpected behavior when used with asynchronous functions or if buttonData changes later on. It would be more robust to place this logic inside an effect (watch, computed, etc.) instead.
Additionally, ensure that bus.emit('pause-autoplay') doesn't cause issues with event listeners already attached. If multiple components are listening for the same event, it's important to make sure you're not overwriting existing listeners unintentionally.
Optimization suggestions could include avoiding unnecessary operations within lifecycle hooks like onMounted.
refactor: Cancel last autoplay audio --story=1017953 --user=刘瑞斌 【优化】多轮对话，语音识别自动播放，会重叠播放 https://www.tapd.cn/57709429/s/1660001