fix: Static image loading path issue and Mobile setting information e…

[wangdan-fit2cloud]

…rror

What this PR does / why we need it?

Summary of your change

Please indicate you've done the following:

• Made sure tests are passing and test coverage is added if needed.
• Made sure commit message follow the rule of Conventional Commits specification.
• Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

[f2c-ci-robot]

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[f2c-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[shaohuzhang1]

The provided code appears to have some minor changes compared to its original version. Here are the key points:

Changes and Suggestions:

1. Import Update:

   // const internalDesc: Record<string, any> = import.meta.glob('@/assets/fx/*/detail.md', {

   Changed to:

   const internalsUrl = '/fx/*/detail.md'

2. Fetch Internal Description:
   Added an async keyword to ensure proper handling of asynchronous operations.

   async function openDescDrawer(row: any) {
     const index = row.icon.replace('icon.png', 'detail.md')
     try {
       const response = await fetch(internalsUrl + '/' + index)
       if (response.ok) {
         const content = await response.text()
         InternalDescDrawerRef.value.open(content, row)
       } else {
         MsgError('Failed to load detailed information.')
       }
     } catch (error) {
       if (process.env.NODE_ENV === "development") {
         console.error(error);
       }
       MsgError('Error while loading detailed information.');
     }
   }

3. **Additional Error Handling and Logging**:
   Added error checking and message display using `MsgError`.

4. **Code Consistency**:
   Removed unnecessary spaces around operators.

These updates improve the robustness and clarity of the code. Ensure that the path `/fx/*/detail.md` correctly maps to where the markdown files are hosted in your project. Also, review the rest of the code to make sure all functionality remains intact and performant.

[shaohuzhang1]

The provided code appears to have some minor formatting issues that can be corrected. Here are the changes:

Code Changes

Line 19:

                <el-option :label="$t('views.applicationWorkflow.nodes.replyNode.replyContent.reference')"

Change style="width: 85px" to just "width=85px".

Line 41 (start of template for label):

          <template #label>
            <div class="flex align-center">
              <div class="mr-4">

Remove extra spaces between <el-tooltip> opening tag and its attributes.

Summary

Ensure consistent spacing, remove unnecessary characters like quotes around inline elements, and adjust CSS property syntax to avoid typos. These modifications should improve readability and adherence to standards.

[shaohuzhang1]

The code is mostly clean and efficient with some minor suggestions:

1. Variable Renaming: source3 can be renamed to something like videoSource, which might clarify its purpose better.

2. URL Parameter Concatenation:

   • In urlParams3, you're appending ?mode=mobile regardless of whether props.apiInputParams exists or not. This might not be necessary unless you want an initial mode set.
   • Consider adding a condition to avoid unnecessary concatenation when props.apiInputParams does not exist.

3. Event Handling Efficiency:

   • If dialogVisible changes from true to false, you could also clear other related states like source1. This ensures that all states are consistent and free of lingering values.

Here's improved version based on these points:

<template>
  <!-- Template remains unchanged -->
</template>

<script setup lang="ts">
import { ref, computed, watch } from 'vue';

// Existing variables remain intact

const urlParams3 = computed(() => {
  return props.apiInputParams ? `?mode=mobile&${props.apiInputParams}` : `${window.location.origin}/api/application/embed/protocol=${window.location.protocol}&host=${window.location.hostname}&token=${""}${''}`;
});

watch(dialogVisible, (bool) => {
  if (!bool) {
    source1.value = '';
    videoSource.value = ''; // Clearing related state
  }
});

This improves readability and maintainability by making explicit decisions about URL parameter handling and reducing potential redundancies.