Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a CONTRIBUTING.md #50

Merged
merged 3 commits into from
Feb 14, 2024
Merged

Add a CONTRIBUTING.md #50

merged 3 commits into from
Feb 14, 2024

Conversation

ingridcrant
Copy link
Contributor

@ingridcrant ingridcrant commented Feb 9, 2024

Initial visual of the CONTRIBUTING.md file
Screenshot 2024-02-09 at 3 08 40 PM

@ingridcrant
Copy link
Contributor Author

The doc doesn't containing a Getting Started section (I feel that this is covered in the README) or a Testing section (on inspection of the codebase there are no tests for developers to run). If there was anything missed, feel free to suggest changes!

@ingridcrant ingridcrant changed the title Add a contributing.md Add a CONTRIBUTING.md Feb 9, 2024
@edif2008 edif2008 self-requested a review February 12, 2024 15:17
Copy link
Member

@edif2008 edif2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple of bits that are missing from these contribution guidelines that would be useful for folks who want to get involved with this project:

  • How to test the injector (these can be found in Makefile)

    • Run tests for the operator (as well as any tests that were added)
      make test
    • Run the local version of the injector for functional testing
      # Go to the K8s environment (example for minikube)
      eval $(minikube docker-env)
      
      # Build the local Docker image for the injector
      make build/secrets-injector/local
      
      # Deploy the injector
      make deploy
      
      # Remove the injector from K8s (i.e. cleanup)
      make undeploy
  • Debugging - Not sure if this would be possible, but it might be worth investigating.

  • Updating documentation - currently manually, in README.

@ingridcrant
Copy link
Contributor Author

Implemented @edif2008 suggested changes. For reference, this is the new visual of the CONTRIBUTING.md file
Screenshot 2024-02-12 at 11 52 01 AM

Copy link
Member

@edif2008 edif2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The contribution guidelines look good to me. These should enable folks to set up their environment and add the enhancements they want to the injector.

Approved! ✅

@ingridcrant ingridcrant merged commit fb837bf into main Feb 14, 2024
2 checks passed
@ingridcrant ingridcrant deleted the contributing branch February 14, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants