Add filters to ListAll() method

[manubouton]

#154

Here is a proposal for integrate a client side filtering mechanism.

WDYT ?

[github-actions]

⚠️ This PR contains unsigned commits. To get your PR merged, please sign those commits (git rebase --exec 'git commit -S --amend --no-edit -n' @{upstream}) and force push them to this branch (git push --force-with-lease).

If you're new to commit signing, there are different ways to set it up:

Sign commits with gpg

Follow the steps below to set up commit signing with gpg:

1. Generate a GPG key
2. Add the GPG key to your GitHub account
3. Configure git to use your GPG key for commit signing

Sign commits with ssh-agent

Follow the steps below to set up commit signing with ssh-agent:

1. Generate an SSH key and add it to ssh-agent
2. Add the SSH key to your GitHub account
3. Configure git to use your SSH key for commit signing

Sign commits with 1Password

You can also sign commits using 1Password, which lets you sign commits with biometrics without the signing key leaving the local 1Password process.

Learn how to use 1Password to sign your commits.

[hculea]

Hi @manubouton ,

Thank you so much for this contribution! We really appreciate you taking the time for this, and agree that filters for the item listing command would make a nice addition to the Go SDK.

Unfortunately, contributions are not possible, at this time, for the 1Password SDKs. For a bit of context: the codebase for the features of the Go SDK, as well as Javascript and Python, lives within a centralized closed-source "core", which allows us to keep the functionality in all of these SDKs in sync. Moreover, this allows us to only implement features once and propagate these changes in all SDKs through code-generation and an FFI interface used to call into this functionality.

The repository here is mostly a wrapper around this core, and the functions here call into it using Extism. The code in items.go, as well as other files is autogenerate - any manual changes to these files will be overwritten with the next release.

While we would love to make this open-source for you to contribute, this is currently still tightly coupled with other 1Password products (dekstop app, browser extension) as well as our internal processes, which makes community contributions not possible at this time.

For now, I'm going to log this as a feature request, and will close the PR. I’m also opening an issue for us to add a note documenting this limitation to CONTRIBUTING.md.

Once again, thank you for your interest to contribute, and we'll make sure to let you know once this feature is added or things change with our contribution policy! 💙

Thanks,
Horia
1Password Developer