Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run sample in pipeline #22

Closed
wants to merge 10 commits into from
Closed

run sample in pipeline #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d1e7b53
run sample in pipeline
sam-1pass Apr 2, 2024
8eeddc8
change example reference
sam-1pass Apr 3, 2024
2ad90dc
add space to vault name
sam-1pass Apr 4, 2024
557104d
use ID-based secret reference
sam-1pass Apr 4, 2024
874a476
use ID-based secret reference for both examples
sam-1pass Apr 4, 2024
67f23d4
test invalid reference in pipeline
sam-1pass Apr 4, 2024
874a548
correct secret reference in correct file
sam-1pass Apr 4, 2024
afc2305
correct secret reference field
sam-1pass Apr 5, 2024
80e78ba
make both example index files match
sam-1pass Apr 5, 2024
13073f3
add esm-example to pipeline
sam-1pass Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/validate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,8 @@ jobs:
- name: Test
env:
OP_SERVICE_ACCOUNT_TOKEN: ${{ secrets.OP_SERVICE_ACCOUNT_TOKEN }}
run: npm test
run: |
npm test
npm run commonjs-example
npm run esm-example

3 changes: 2 additions & 1 deletion examples/index.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ async function fetchSecret() {
});

// Fetches a secret.
return await client.secrets.resolve("op://vault/item/field");
// See syntax here: https://developer.1password.com/docs/cli/secrets-reference-syntax/
return await client.secrets.resolve("op://SDKs Test/Test Login/username");
}

fetchSecret().then(console.log)
3 changes: 2 additions & 1 deletion examples/index.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,6 @@ const client = await createClient({
});

// Fetches a secret.
const secret = await client.secrets.resolve("op://vault/item/field");
// See syntax here: https://developer.1password.com/docs/cli/secrets-reference-syntax/
const secret = await client.secrets.resolve("op://SDKs Test/Test Login/username");
console.log(secret)
Loading