new(redis-cli): Add support for Redis CLI with password as environment variable and command-line flags#276

Open

arunsathiya wants to merge 48 commits intomainfrom new/redis

+413

Commits on Aug 17, 2023

Working shell plugin with environment variable support for the password. Does not support host, port or database fields yet.
arunsathiya
committed
Use NotForVersion check instead of defining each version flag one by one.
arunsathiya
committed
Update CLI docs URL
arunsathiya
committed
Add test for environment variable importer
arunsathiya
committed
Add support for host and port, in conjunction with password as environment variable
arunsathiya
committed
Better description for the Redis environment variable and flags provisioner
arunsathiya
committed
Add username to the credential as well, thus allowing scoped access to the database
arunsathiya
committed
Use shell plugin even without args, if one wants to enter redis shell mode and run queries in there instead of passing as args
arunsathiya
committed
Introduce second credential that'd be used only for authenticating to Redis Enterprise Cloud using rediscloud Terraform provider
arunsathiya
committed
Do not use 1Password authentication when --help flag is used
arunsathiya
committed
Define ID for the credential selection and description for the credential selection prompt
arunsathiya
committed
Switch from credential selection to credential reference with just UserCredentials; SecretKey credential remains defined but not necessarily used with the RedisCLI executable
arunsathiya
committed
Mark host and port as optional fields
arunsathiya
committed
Rename argument provision functions to AddArgsFirst and AddArgsLast
arunsathiya
committed
Introduce flags provision and chained provision at the SDK level and use for redis-cli binary
arunsathiya
committed
Rename flags to args
arunsathiya
committed
Describe the new arguments and chained provisioners, and better handling of arguments position
arunsathiya
committed
Better handling of the arguments index using a map that maps the arguments to an index that they should be placed at
arunsathiya
committed
Describe what ArgsProvisioner does better
arunsathiya
committed
Remove unnecessary provisioner field in the ChainedProvisioner
arunsathiya
committed
Remove validation check that checks if multiple credentials are defined\, because multi-credential support is beginning to be possible
arunsathiya
committed
Switch from provisioning at a specific index to either immediately after the executable name, or at the end, because specific index provisioning breaks some cases
arunsathiya
committed
Address feedback to rename credential name to APIKey and credential function to RedisCloudAPIKey
arunsathiya
committed
Add ManagementURL for the Redis Cloud API Keys credential
arunsathiya
committed
Remove length for account key and user key fields, because they don't seem consistent, at least in the case of user key
arunsathiya
committed
Remove the description that the default username will be default, because by default, a redis server does not require an username or password to connect to it.
arunsathiya
committed
Revert "Switch from provisioning at a specific index to either immediately after the executable name, or at the end, because specific index provisioning breaks some cases"
arunsathiya
committed
Rename AddArgs helper function to AddArgsAtIndex, and in the ArgsProvisioner, build a safeguard to ensure that arguments are not provisioned out of bounds.
arunsathiya
committed
Swap around the index and args params in ArgsAtIndex function for better readability
arunsathiya
committed
Reintroduce AddArgs helper function and fix FileProvisioner breakage
arunsathiya
committed
Remove Arguments Provisioner completely and introduce redis-specific arguments provision that injects arguments at the first index. This works along with the environment variable provisioner as a c…
arunsathiya
committed
Update redis Enterprise Cloud platform credential fields to the modern names: Account Key and User Key. Credential name remains API Key
arunsathiya
committed
Remove unused AccessKey and SecretKey field names
arunsathiya
committed
Move executable code from redis-cli to redis_cli as snake case is more common in go
arunsathiya
committed
Remove optional field in certain field name structs because the default value is false
arunsathiya
committed
Since redis CLI requires injecting arguments only at index 1, indexToProvisionAt param is removed
arunsathiya
committed
Remove chained provisioner and add REDISCLI_AUTH directly in custom redis provisioner
arunsathiya
committed
Branch out rediscloud as a separate shell plugin
arunsathiya
committed
Update rediscloud platform homepage address

arunsathiya
and
florisvdg
committed
Since rediscloud is a separate shell plugin now, rename credential function from RedisCloudAPIKey to APIKey
arunsathiya
committed
Revert "Remove validation check that checks if multiple credentials are defined\, because multi-credential support is beginning to be possible"
arunsathiya
committed
Switch redis provision from map-based struct to string, because it allows for more control over the order in which the arguments are provisioned
arunsathiya
committed
Update test to verify the provisioned arguments and expected command line arguments but it's not working just yet due to slice range issues
arunsathiya
committed
Refactor argument provisioning logic to avoid string splitting
arunsathiya
committed
Skip 1Password authentication when an user enters a custom host or port as well
arunsathiya
committed
Fix provisoner test
arunsathiya
committed
Safeguard in the arguments injection code to prevent out of bounds errors, but this is not necessarily a concern in redis-cli because we always provision at index 1 and redis-cli is the minimum req…
arunsathiya
committed
Don't skip auth for certain flags, rather use them in conjunction with 1Password-stored secrets to provision
arunsathiya
committed