Added Scaleway Shell Plugin #314

parthiv11 · 2023-06-24T08:30:25Z

Overview

Used previous PR for this Scaleway Shell Plugin code
Created a new plugin

Related Issue(s)

Resolves: New plugin: Scaleway CLI #189
Relates: #

How To Test

Changelog

parthiv11 · 2023-06-24T08:39:26Z

@arunsathiya please help me to proceed

techcraver · 2023-06-26T14:45:32Z

Hello! Is this a submission for the 1Password Hackathon with Hashnode? If so, when you're ready, please be sure you write a blog post on Hashnode to make your submission official. Full instructions are on the Hackathon page.

parthiv11 · 2023-06-26T17:07:17Z

Thank you for information, I will write blog

But can you please help me in this plugin

arunsathiya · 2023-06-26T19:41:13Z

Hi Parthiv, thanks for confirming.

Yes, reviewing this PR is on my radar. I'll follow up soon!

AndyTitu

Thank you for the contribution @parthiv11 . This PR is on the right track. Here's the documentation for the scale way CLI (for other reviewers) which let's us know that these env vars actually work: sdk/schema/credname/names.go

Did a first iteration and left the first suggestions. After you're done with those, feel free to move on to resolving the TODO comments you've added.

plugins/scaleway/api_key.go

hculea

Mostly nits, thank you for your contribution! ❤️

plugins/scaleway/api_key.go

hculea

Thanks for the improvements! I think there are a few open comments from prior reviews, let's make sure those get addressed as well.

sdk/schema/fieldname/names.go

hculea

Looks great! Only a few nits and ready to go IMO 👍

hculea · 2023-07-05T09:59:32Z

plugins/scaleway/api_key.go

+	AccessKey             string `yaml:"access_key"`
+	SecretKey             string `yaml:"secret_key"`
+	DefaultOrganizationID string `yaml:"default_organization_id"`
+	DefaultProjectID      string `yaml:"default_project_id"`


Is this attribute used anywhere?

I noticed the same thing. @parthiv11, let's remove this since this is not being used anywhere. But before we do, would you know if the Scaleway CLI needs both the organization ID and the project ID to function?

sdk/schema/fieldname/names.go

plugins/scaleway/api_key_test.go

hculea · 2023-07-07T15:05:09Z

Hey @parthiv11 , I see there hasn't been any activity on this PR in a bit, is there anything that we can help you with?

We'd love to get this to the finish line together! 🚀

parthiv11 · 2023-07-11T14:10:31Z

Sorry for delay,
Made changes as suggested

arunsathiya

This looks 95% done, thanks for your contribution @parthiv11! There's only one major task to complete here: support importing of multiple profiles from the config file. Could you give it a try? We'll be around if you need a hand. 😄

arunsathiya · 2023-07-11T15:12:26Z

plugins/scaleway/scw.go

+		Name:    "Scaleway CLI",
+		Runs:    []string{"scw"},
+		DocsURL: sdk.URL("https://www.scaleway.com/en/cli"),
+		NeedsAuth: needsauth.IfAll(


Let's skip for -p as well, because that applies only when the configuration file exists on the computer. So, it's not relevant when a shell plugin is being used.

plugins/scaleway/api_key.go

arunsathiya · 2023-07-11T15:14:24Z

plugins/scaleway/api_key.go

+	AccessKey             string `yaml:"access_key"`
+	SecretKey             string `yaml:"secret_key"`
+	DefaultOrganizationID string `yaml:"default_organization_id"`
+	DefaultProjectID      string `yaml:"default_project_id"`


I noticed the same thing. @parthiv11, let's remove this since this is not being used anywhere. But before we do, would you know if the Scaleway CLI needs both the organization ID and the project ID to function?

plugins/scaleway/api_key_test.go

arunsathiya · 2023-07-11T15:18:18Z

plugins/scaleway/api_key.go

+		if config.DefaultZone != "" {
+			fields[fieldname.DefaultZone] = config.DefaultZone
+		}
+		out.AddCandidate(sdk.ImportCandidate{


It seems that Scaleway config file supports the concepts of profiles. Could we import the profile name as a Namehint? You'll need to set up at least two profiles to test the importer. Example:

profiles: first: access_key: redacted secret_key: redacted default_organization_id: redacted default_project_id: redacted default_zone: fr-par-1 default_region: fr-par # api_url: https://api.scaleway.com # insecure: false second: access_key: redacted secret_key: redacted default_organization_id: redacted default_project_id: redacted default_zone: fr-par-1 default_region: fr-par # api_url: https://api.scaleway.com # insecure: false

There's an example of how to import multiple profiles in the Fastly shell plugin.

hculea · 2023-07-17T10:44:30Z

Please have a look over your tests and lint 😄 You can run tests locally using make test, let us know if we can help you get those rolling!

AndyTitu · 2023-08-30T11:48:32Z

@parthiv11 is there a way we can help you move this forward?

parthiv11 · 2023-09-07T11:24:52Z

@AndyTitu Not able to test it currently as I don't have scaleway account

parthiv11 and others added 2 commits June 24, 2023 11:54

Added Scaleway plugin code from old

5285666

Merge branch '1Password:main' into scaleway

d145305

AndyTitu added the waiting-on-reviewer signals that a certain PR is waiting for a review from a 1Password team member label Jun 26, 2023

arunsathiya added the hashnode hackathon Ideas and inspiration for the hackathon running from June 1st - June 30th label Jun 26, 2023

Merge branch '1Password:main' into scaleway

451a9cd

parthiv11 marked this pull request as ready for review June 27, 2023 13:25

arunsathiya self-requested a review June 28, 2023 15:20

arunsathiya assigned parthiv11 Jun 28, 2023

AndyTitu reviewed Jun 28, 2023

View reviewed changes

plugins/scaleway/api_key.go Show resolved Hide resolved

plugins/scaleway/api_key.go Outdated Show resolved Hide resolved

Merge branch '1Password:main' into scaleway

7cc3e71

hculea reviewed Jun 29, 2023

View reviewed changes

plugins/scaleway/api_key.go Outdated Show resolved Hide resolved

plugins/scaleway/api_key.go Outdated Show resolved Hide resolved

plugins/scaleway/api_key.go Outdated Show resolved Hide resolved

plugins/scaleway/api_key.go Outdated Show resolved Hide resolved

parthiv11 added 3 commits June 30, 2023 12:09

Changes made as Suggested by Maintainer

bc0a2a2

Changes made as Suggested by Maintainer

28475e7

DefaultOrganization DefaultZone added to fieldname/names.go

1237d89

hculea reviewed Jun 30, 2023

View reviewed changes

sdk/schema/fieldname/names.go Outdated Show resolved Hide resolved

parthiv11 added 2 commits July 1, 2023 01:01

Reformated sdk/schema/fieldname/names.go

b283ae7

formatted codebase

192a685

hculea requested review from hculea and removed request for arunsathiya July 5, 2023 08:08

hculea reviewed Jul 5, 2023

View reviewed changes

hculea self-requested a review July 5, 2023 10:09

improved tests

7455ea3

arunsathiya self-requested a review July 11, 2023 15:00

arunsathiya reviewed Jul 11, 2023

View reviewed changes

parthiv11 and others added 3 commits July 13, 2023 01:37

Merge branch '1Password:main' into scaleway

1fc9360

Some updates

44db034

Updated config import

be57756

AndyTitu added the in-progress this PR is being worked on/comments are in the process of being addressed by the contributor label Aug 30, 2023

AndyTitu removed the waiting-on-reviewer signals that a certain PR is waiting for a review from a 1Password team member label Aug 30, 2023

Merge branch 'main' into scaleway

115a6a7

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added Scaleway Shell Plugin #314

Added Scaleway Shell Plugin #314

parthiv11 commented Jun 24, 2023 •

edited

Loading

parthiv11 commented Jun 24, 2023

techcraver commented Jun 26, 2023 •

edited

Loading

parthiv11 commented Jun 26, 2023

arunsathiya commented Jun 26, 2023

AndyTitu left a comment

hculea left a comment

hculea left a comment

hculea left a comment

hculea Jul 5, 2023

arunsathiya Jul 11, 2023

hculea commented Jul 7, 2023

parthiv11 commented Jul 11, 2023

arunsathiya left a comment

arunsathiya Jul 11, 2023

arunsathiya Jul 11, 2023

arunsathiya Jul 11, 2023

hculea commented Jul 17, 2023

AndyTitu commented Aug 30, 2023

parthiv11 commented Sep 7, 2023

Added Scaleway Shell Plugin #314

Are you sure you want to change the base?

Added Scaleway Shell Plugin #314

Conversation

parthiv11 commented Jun 24, 2023 • edited Loading

Overview

Related Issue(s)

How To Test

Changelog

parthiv11 commented Jun 24, 2023

techcraver commented Jun 26, 2023 • edited Loading

parthiv11 commented Jun 26, 2023

arunsathiya commented Jun 26, 2023

AndyTitu left a comment

Choose a reason for hiding this comment

hculea left a comment

Choose a reason for hiding this comment

hculea left a comment

Choose a reason for hiding this comment

hculea left a comment

Choose a reason for hiding this comment

hculea Jul 5, 2023

Choose a reason for hiding this comment

arunsathiya Jul 11, 2023

Choose a reason for hiding this comment

hculea commented Jul 7, 2023

parthiv11 commented Jul 11, 2023

arunsathiya left a comment

Choose a reason for hiding this comment

arunsathiya Jul 11, 2023

Choose a reason for hiding this comment

arunsathiya Jul 11, 2023

Choose a reason for hiding this comment

arunsathiya Jul 11, 2023

Choose a reason for hiding this comment

hculea commented Jul 17, 2023

AndyTitu commented Aug 30, 2023

parthiv11 commented Sep 7, 2023

parthiv11 commented Jun 24, 2023 •

edited

Loading

techcraver commented Jun 26, 2023 •

edited

Loading