Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eksctl support to AWS plugin #500

Merged
merged 3 commits into from
Dec 5, 2024

Conversation

skpaz
Copy link
Contributor

@skpaz skpaz commented Dec 2, 2024

Overview

Adds rudimentary eksctl support to the AWS plugin. eksctl uses the same authentication schema as aws and cdk, so all I did was add eksctl.go, the related executable to plugin.go, and tested it locally.

https://eksctl.io/

eksctl is maintained by Amazon.

Type of change

  • Created a new plugin
  • Improved an existing plugin
  • Fixed a bug in an existing plugin
  • Improved contributor utilities or experience

Related Issue(s)

How To Test

Any eksctl command, ex:

14:34:30 › ~/git/skpaz/shell-plugins »
∟ ⌥ skpaz/add-eksctl-to-aws ↑ % eksctl get clusters --region us-west-2
###########################################################################
# WARNING: 'aws' is not from the official registry.                       #
# Only proceed if you are the developer of 'aws'.                         #
# Otherwise, delete the file at /Users/sean/.config/op/plugins/local/aws. #
###########################################################################
NAME			REGION		EKSCTL CREATED
KKR-BORIS		us-west-2	False
basic-cluster-kkr-01	us-west-2	True
john-test-cluster	us-west-2	True
johnl-gex-fullstack	us-west-2	True
vw-kkr-demo01		us-west-2	False

Local plugin:

15:27:09 › ~/git/skpaz/shell-plugins »
∟ ⌥ skpaz/add-eksctl-to-aws % op plugin list|grep -i aws
Local Build           aws                AWS                   Access Key ID, Secret Access Key
Local Build           cdk                AWS                   Access Key ID, Secret Access Key
Local Build           eksctl             AWS                   Access Key ID, Secret Access Key

I haven't tested this exhaustively, so it's possible there might be flags other than --profile that need to be added to cli_provisioner.go, etc. I'll be running with it for the next week or so to see if I encounter any issues.

Changelog

The AWS plugin now supports eksctl, AWS' EKS CLI.

@SimonBarendse SimonBarendse requested a review from hculea December 4, 2024 18:50
@SimonBarendse
Copy link
Member

Thank you for the contribution @skpaz ! 🙌

@skpaz
Copy link
Contributor Author

skpaz commented Dec 4, 2024

Fixed the gofmt issue for plugins.go that popped during the test & validate stage.

Copy link
Member

@hculea hculea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

@hculea hculea merged commit f03bbc8 into 1Password:main Dec 5, 2024
3 checks passed
@skpaz skpaz deleted the skpaz/add-eksctl-to-aws branch December 5, 2024 14:37
@skpaz
Copy link
Contributor Author

skpaz commented Dec 5, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add eksctl support to AWS plugin
3 participants