-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for document data source #161
Conversation
only tested w cli
This looks related to #51. I have a connect API setup for my Kubernetes clusters, I might be able to test this if I get some time to build and deploy your branch. |
Ran |
@volodymyrZotov comments adressed |
Speculating with myself: Actually, the fact that descriptions are missing from the schema might be a slight issue if things like |
Ok, I have something that seems to work locally against main. Will create a superseding PR when I have cleaned up it a little bit more. |
Superceded by #171 @volodymyrZotov would you review that one instead, please? |
@sdahlbac Hi, was about to write to you that there was a migration and you would need to adjust your PR because of that, but I see you figured it out already 👍 Will take another look there. |
I have have only tested this with unittests and cli, as I do not have a connect.
content_base64
version)Roundtrip test:
(where 2 is the third file for that item, added via the UI)
I had to use the
op read
approach rather thanop document get
(unless I am missing an undocumented feature) to be able to handle multiple files.I have not tried to implement a resource, since as far as I understood connect cannot support it and I don't see a way to distinguish between the two backends.
Thedocument
category is available also for resource, that is slightly incorrect.