Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup old provider code #172

Merged
merged 4 commits into from
May 17, 2024
Merged

Cleanup old provider code #172

merged 4 commits into from
May 17, 2024

Conversation

edif2008
Copy link
Member

@edif2008 edif2008 commented May 17, 2024 •
edited
Loading

Sumary

This PR does the following:

  • Remove the onepassword directory which contained the old implementation of the provider (with terraform-plugin-sdk)
  • Remove the commented code related to old implementation in main.go
  • Remove github.com/hashicorp/terraform-plugin-sdk/v2 package from go.mod and vendor.
  • Update packages to latest versions.

No testing is needed since this doesn't affect the current build of the provider.

edif2008 added 4 commits May 17, 2024 18:22
@edif2008
Fix import
6cfd3f3 
This points to the package in the internal directory rather than the old onepassword directory.
@edif2008
Remove old provider code
3c3d0df
@edif2008
Remove terraform-plugin-sdk from Go mod
cc7d9fe
@edif2008
Update packages to latest version
0b6227a
jillianwilson
jillianwilson approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@jillianwilson jillianwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have verified that the files removed are the ones that are expected to be moved after our migration to the terraform provider framework

@edif2008 edif2008 merged commit 69451ed into main May 17, 2024
6 checks passed
@edif2008 edif2008 deleted the cleanup-old-provider-code branch May 17, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jillianwilson jillianwilson jillianwilson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edif2008 @jillianwilson