Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow swift decorator constraints to apply to generics #173

Merged
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
#[typeshare(swift = "Equatable")]
pub struct Button<T> {
/// Label of the button
pub label: String,
/// Accessibility label if it needed to be different than label
pub accessibility_label: Option<String>,
/// Optional tooltips that provide extra explanation for a button
pub tooltip: Option<String>,
/// Button action if there one
pub action: Option<T>,
/// Icon if there is one
pub icon: Option<Icon>,
/// Button state
pub state: ButtonState,
/// Button Mode
pub style: ButtonStyle,
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
import Foundation

public struct Button<T: Codable & Equatable>: Codable, Equatable {
/// Label of the button
public let label: String
/// Accessibility label if it needed to be different than label
public let accessibility_label: String?
/// Optional tooltips that provide extra explanation for a button
public let tooltip: String?
/// Button action if there one
public let action: T?
/// Icon if there is one
public let icon: Icon?
/// Button state
public let state: ButtonState
/// Button Mode
public let style: ButtonStyle

public init(label: String, accessibility_label: String?, tooltip: String?, action: T?, icon: Icon?, state: ButtonState, style: ButtonStyle) {
self.label = label
self.accessibility_label = accessibility_label
self.tooltip = tooltip
self.action = action
self.icon = icon
self.state = state
self.style = style
}
}
8 changes: 7 additions & 1 deletion core/src/language/swift.rs
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,13 @@ impl Language for Swift {
.for_each(|d| decs.push(d.clone()));
}

let generic_constraint_string = default_generic_constraints.get_constraints().join(" & ");
// Include any decorator constraints on the generic types.
let generic_constraint_string = default_generic_constraints
.get_constraints()
.chain(decs.iter())
.collect::<BTreeSet<_>>()
.into_iter()
.join(" & ");

writeln!(
w,
Expand Down
1 change: 1 addition & 0 deletions core/tests/snapshot_tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -569,4 +569,5 @@ tests! {
go
];
can_generate_anonymous_struct_with_skipped_fields: [swift, kotlin, scala, typescript, go];
generic_struct_with_constraints_and_decorators: [swift];
}
Loading