Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

havelessbemore - New Submission #2

Open
wants to merge 68 commits into
base: main
Choose a base branch
from

Conversation

havelessbemore
Copy link

@havelessbemore havelessbemore commented May 23, 2024

Check List:

  • Tests pass (./test.sh <username> shows no differences between expected and actual outputs)
  • All formatting changes by the build are committed
  • Your launch script is named calculate_average_<username>.sh (make sure to match casing of your GH user name) and is executable
  • Output matches that of calculate_average_baseline.sh
  • Execution time:

    • Min: 11.1s
    • Avg: 11.6s
    • Max: 12.0s
    • Samples: 10 runs, 5s apart
  • Execution time of reference implementation:

    • Baseline:

      • Min: 5m45.6s
      • Avg: 5m46.9s
    • Edgar-P-yan:

      • Min: 34.8s
      • Avg: 36.1s

Specs:

  • Machine:

    • Model: MacBook Air
    • Chip: Apple M2
    • Cores: 8 (4 performance + 4 efficiency)
    • Memory: 8 GB
    • OS: MacOS Sonoma
  • Other:

    • NodeJS: v20.13.1
    • Input file: ~13.8 GB

…lues from const enums B and C to not be inlined, which also caused the creation of enums B and C in the built output file. Combining the const enums into one file fixes this so all const enum values are properly inlined. Since these values were in the hot loop, this notably improved performance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant