Feature/export variables #1232
Merged
Feature/export variables #1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Божественно |
nixel2007
reviewed
Jun 2, 2020
| @@ -0,0 +1,2 @@ | |||
| diagnosticMessage=<Message> | |||
There was a problem hiding this comment.
Надо дозаполнить этот файл и перезапустить precommit для обновления доков и схемы
There was a problem hiding this comment.
Поправил описание диагностики
nixel2007
reviewed
Jun 2, 2020
| } | ||
|
|
||
| @Override | ||
| public void visitVariable(VariableSymbol variable) { |
There was a problem hiding this comment.
я же правильно понимаю, что в общем случае надо еще вставлять вызов super.visitSomething в конец метода? конкретно тут не надо, но вообще для продолжения обхода дерева (по аналогии с наследниками AbstractVisitorDiagnostic) - надо
nixel2007
reviewed
Jun 2, 2020
| @Test | ||
| void test() throws IOException { | ||
|
|
||
| String content = "Перем Перем1 Экспорт,\n Перем2\n,Перем53 \nЭкспорт\n\n\n"; |
There was a problem hiding this comment.
Перенеси содержимое в файл, пожалуйста.
По файлам работает ряд smoke-тестов, который позволяет отлавливать дополнительные косяки на интеграции, а в таком виде эта возможность теряется.
alkoleft
force-pushed
the
feature/exportVariables
branch
from
b8b70dd
to
48bc68e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Связанные задачи
Closes:
Closes #1043
Closes #1208
Чеклист
Общие
gradlew precommit)Для диагностик
Дополнительно