Правило - "Путь к данным" не заполнен у полей формы #1831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- и для полей формы - и для полей динам.списков 1c-syntax#1122 1c-syntax#1830
This reverts commit 4324ba6.
This reverts commit d87eb5b.
nixel2007
requested changes
Sep 19, 2021
|
|
||
| form.getData().getPlainChildren().stream() | ||
| .filter(WrongDataPathForFormElementsDiagnostic::wrongDataPath) | ||
| .forEach(formItem -> diagnosticStorage.addDiagnostic(range, |
There was a problem hiding this comment.
Почему ты высчитываешь range от модуля формы, но кидаешь его на uri модуля приложения?
There was a problem hiding this comment.
Исправил, теперь и модули форм анализируются, если они есть.
@nixel2007
| scope = DiagnosticScope.BSL, | ||
| modules = { | ||
| // todo переделать, когда появится привязка к объектам метаданных | ||
| ModuleType.ManagedApplicationModule |
There was a problem hiding this comment.
В такой настройке диагностика будет всегда кидать ошибку на модуль приложения. Лучше кидать ошибку на модуль формы, если он есть, и на модуль приложения только для остальных случаев.
There was a problem hiding this comment.
Исправил, теперь и модули форм анализируются, если они есть.
nixel2007
reviewed
Sep 19, 2021
...github/_1c_syntax/bsl/languageserver/diagnostics/WrongDataPathForFormElementsDiagnostic.java
Show resolved
Hide resolved
а не только модуль приложения если модуля у формы нет, замечание вешается на модуль приложения
|
@nixel2007 Замечания исправлены. Посмотришь ПР ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Реализована проверка неверных путей для элементов формы, в т.ч. и для полей динамического списка
Связанные задачи
Closes #1122
Closes #1830
Чеклист
Общие
gradlew precommit)Для диагностик
Дополнительно