Модификация диагностики LineLengthDiagnostic #1842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nixel2007
reviewed
Sep 29, 2021
| } else { | ||
| var descriptionRanges = documentContext.getSymbolTree().getMethods().stream() | ||
| .map(MethodSymbol::getDescription) | ||
| .filter(Optional::isPresent) |
There was a problem hiding this comment.
filter+map на flatMap(Optional::stream)
nixel2007
reviewed
Sep 29, 2021
| if (first.getStart().getLine() + 1 > token.getLine()) { | ||
| return false; | ||
| } else if (first.getEnd().getLine() + 1 < token.getLine()) { | ||
| descriptionRanges.remove(first); |
There was a problem hiding this comment.
интересный подход с рекурсией вместо цикла :)
There was a problem hiding this comment.
а коллекция из стрима получается отсортированная? не нужно ли добавить ordered по номеру строки токена?
There was a problem hiding this comment.
утверждается, что стрим не меняет порядок входных элементов, значит дополнительно упорядочивать не нужно
https://www.baeldung.com/java-stream-ordering
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Добавил опционную настройку для возможности отключать комментарии-описания методов
Связанные задачи
Closes: #726
Чеклист
Общие
gradlew precommit)Для диагностик
Дополнительно