-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Доработка ReferenceIndex - Исправлен расчет ссылок на символы-методы + падение анализа #2833
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
2161b20
падающий тест для присваивания
artbear da7b1bd
пропущенное присваивание находится
artbear ab15179
падающий кейс
artbear e13337d
исправил расчет ссылок на общие модули
artbear 02bae50
уточнил условие для параметров
artbear 5637ef7
падающий кейс через публичное API RefIndex
artbear b154583
Sonar - lambda
artbear 6d10965
ускорение + исправление замечанияй ревью
artbear f32f949
падающий кейс для присванием с менеджерами объектов
artbear c262312
учел присваивание с менеджерами объектов
artbear 6ba6b84
Merge remote-tracking branch 'origin/develop' into ref-index-fix-2832
artbear 1759f79
исправил merge
artbear dc9a69e
еще исправление последствий merge
artbear 6136f67
убран фильтр ReferenceIndex::isReferenceAccessible + тест
artbear 98163e4
Revert "убран фильтр ReferenceIndex::isReferenceAccessible + тест"
artbear 6cd23bd
Update src/main/java/com/github/_1c_syntax/bsl/languageserver/referen…
artbear 0e2d0d8
Update src/main/java/com/github/_1c_syntax/bsl/languageserver/referen…
artbear c1d35c8
Исправлена ошибка падения анализа
artbear c3c2cc9
Улучшена обработка описаний оповещения
artbear 43676d0
Merge remote-tracking branch 'origin/develop' into ref-index-fix-2832
artbear 01e1b54
Merge remote-tracking branch 'my-artbear/ref-index-fix-2832' into ref…
artbear 3b284d3
убрано лишнее вычисление
artbear 8fae65a
Update src/main/java/com/github/_1c_syntax/bsl/languageserver/referen…
nixel2007 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
а в каком случае сюда может прилететь пустой mdoRef?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
в этот параметр передается результат getModule, который теперь может возвращать пустую строку, если не может получить модуль.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
мне самому не нравится проверка mdoRef на пустоту.
но другой вариант с выносом этой проверки на уровень выше также не очень - дубль проверки на пустоту будет.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Не совсем понимаю. Где? В какой строке? Я не могу припомнить ситуации, чтобы мдореф был пуст. Если MdoRefBuilder не может построить mdoRef, он возвращает uri
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
посмотри код вызова вызовов getModule и сам метод getModule и увидишь.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Посмотрел. мне не нравится, что у метода addCallbackMethodCall появилось право не добавлять вызов метода. лучше все же продублировать проверку на пустоту, но не размазывать ответственность. Либо сделать, чтобы getModule возвращал Optional, например.