build(deps): bump org.springframework.boot from 3.1.5 to 3.2.1 #3217
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [org.springframework.boot](https://github.com/spring-projects/spring-boot) from 3.1.5 to 3.2.1. - [Release notes](https://github.com/spring-projects/spring-boot/releases) - [Commits](spring-projects/spring-boot@v3.1.5...v3.2.1) --- updated-dependencies: - dependency-name: org.springframework.boot dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
WalkthroughThe project has been updated with a minor Spring Boot plugin version bump and an infrastructure role annotation added to a bean within the application context. These changes suggest a focus on keeping dependencies up-to-date and refining the application's configuration management. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChat with CodeRabbit Bot (
|
stringInterner инжектится внутрь DiagnosticBeanPostProcessor, поэтому во избежание ругани он должен быть инфраструктурным бином
|
@dependabot merge |
Qodana Community for JVM17 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
|
@coderabbitai review |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (2)
- build.gradle.kts (1 hunks)
- src/main/java/com/github/_1c_syntax/bsl/languageserver/infrastructure/UtilsConfiguration.java (1 hunks)
Additional comments: 5
src/main/java/com/github/_1c_syntax/bsl/languageserver/infrastructure/UtilsConfiguration.java (4)
25-25: The addition of the import statement for
BeanDefinitionis necessary due to the usage ofBeanDefinition.ROLE_INFRASTRUCTUREin the annotations.28-28: The addition of the import statement for
Roleis necessary for the@Roleannotation used in the class and method.34-34: The
@Role(BeanDefinition.ROLE_INFRASTRUCTURE)annotation on theUtilsConfigurationclass designates the role of the bean within the Spring context. Ensure that this change aligns with the intended behavior and lifecycle management of the beans defined in this configuration class.41-41: The
@Role(BeanDefinition.ROLE_INFRASTRUCTURE)annotation on thestringInternermethod is consistent with the class-level annotation. Verify that this specific bean should also be marked as infrastructure, as it may affect its processing by the Spring container.build.gradle.kts (1)
- 19-19: The update of the
org.springframework.bootplugin to version3.2.1is part of the routine maintenance to keep the project dependencies up-to-date. Ensure that this version is compatible with other dependencies and that no breaking changes affect the project.
|
One of your CI runs failed on this pull request, so Dependabot won't merge it. Dependabot will still automatically merge this pull request if you amend it and your tests pass. |
|
@dependabot merge |
|
@coderabbitai review |
|
There was a problem hiding this comment.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files selected for processing (1)
- src/test/java/com/github/_1c_syntax/bsl/languageserver/diagnostics/DenyIncompleteValuesDiagnosticTest.java (1 hunks)
Additional comments: 5
src/test/java/com/github/_1c_syntax/bsl/languageserver/diagnostics/DenyIncompleteValuesDiagnosticTest.java (5)
93-93: The mocking of
getMdObjectto returninfoRegis standard practice in tests and appears to be implemented correctly.96-96: The conditional mocking of
infoReg.getModules()to return an empty list based on thenoneModulesflag is implemented correctly.98-101: The mocking of
configuration.getChildren()to return a list containing onlyinfoRegis standard practice in tests and appears to be implemented correctly.100-101: The mocking of
documentContext.getServerContext()to return a spy ofserverContextwith a mockedgetConfigurationmethod is standard practice in tests and appears to be implemented correctly.86-101: > Note: This review was outside the patches, and no patch overlapping with it was found. Original lines [102-108]
The use of
getDiagnosticsand subsequent assertions withassertThatto verify the expected diagnostic message and size is standard testing practice and appears to be implemented correctly.
| final var infoReg = spy((InformationRegister) context.getConfiguration().findChild(MdoReference.create(MDOType.INFORMATION_REGISTER, | ||
| "РегистрСведений1")).orElseThrow() |
There was a problem hiding this comment.
The creation of infoReg spy object is done correctly, but it's important to ensure that the orElseThrow() method provides a meaningful exception message for better debugging in case the findChild method returns an empty Optional.
- "РегистрСведений1")).orElseThrow()
+ "РегистрСведений1")).orElseThrow(() -> new NoSuchElementException("InformationRegister 'РегистрСведений1' not found."))Committable suggestion
❗ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| final var infoReg = spy((InformationRegister) context.getConfiguration().findChild(MdoReference.create(MDOType.INFORMATION_REGISTER, | |
| "РегистрСведений1")).orElseThrow() | |
| final var infoReg = spy((InformationRegister) context.getConfiguration().findChild(MdoReference.create(MDOType.INFORMATION_REGISTER, | |
| "РегистрСведений1")).orElseThrow(() -> new NoSuchElementException("InformationRegister 'РегистрСведений1' not found."))) |
dependabot
bot
deleted the
dependabot/gradle/org.springframework.boot-3.2.1
branch
Bumps org.springframework.boot from 3.1.5 to 3.2.1.
Release notes
Sourced from org.springframework.boot's releases.
... (truncated)
Commits
8bb60eeRelease v3.2.17d1982fMerge branch '3.1.x'53528d3Next development version (v3.1.8-SNAPSHOT)3222458Merge branch '3.1.x'66e9c77Upgrade Ubuntu version in CI imagesf31ffbfDon't duplicate META-INF entries in nested directory jarsb218528Merge branch '3.1.x'20529eaDrop Netty restrictionbf7d1e4Merge branch '3.1.x'e754c91Upgrade to Spring WS 4.0.9Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot will merge this PR once CI passes on it, as requested by @nixel2007.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditionsSummary by CodeRabbit