Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new bsl-parser ver #3219

Merged
merged 1 commit into from
Jan 7, 2024
Merged

new bsl-parser ver #3219

merged 1 commit into from
Jan 7, 2024

Conversation

theshadowco
Copy link
Member

@theshadowco theshadowco commented Jan 7, 2024

Описание

Связанные задачи

Closes

Чеклист

Общие

  • Ветка PR обновлена из develop
  • Отладочные, закомментированные и прочие, не имеющие смысла участки кода удалены
  • Изменения покрыты тестами
  • Обязательные действия перед коммитом выполнены (запускал команду gradlew precommit)

Для диагностик

  • Описание диагностики заполнено для обоих языков (присутствуют файлы для обоих языков, для русского заполнено все подробно, перевод на английский можно опустить)

Дополнительно

Summary by CodeRabbit

  • Refactor
    • Updated bsl-parser to version 0.24.0 for improved performance and stability.
    • Introduced a new dependency bsl-parser-core version 0.1.0 to enhance core functionalities.

Copy link

coderabbitai bot commented Jan 7, 2024

Walkthrough

The build.gradle.kts file in the project has been updated to upgrade an existing dependency and introduce a new one. The bsl-parser version was bumped up, signifying potential new features or fixes, and a brand-new dependency, bsl-parser-core, is now part of the project, likely to modularize or enhance functionality.

Changes

File Change Summary
build.gradle.kts Upgraded bsl-parser to 0.24.0, added bsl-parser-core version 0.1.0

Poem

🐇
To code anew, we hop and leap,
With versions fresh, our build shall keep.
In gradle.kts, the lines do weave,
A parser's core, in spring, we receive.
🌱

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit's AI:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@ghost
Copy link

ghost commented Jan 7, 2024

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 31f3ac3 and 631fd2d.
Files selected for processing (1)
  • build.gradle.kts (1 hunks)
Additional comments: 3
build.gradle.kts (3)
  • 77-77: The bsl-parser dependency has been updated to version 0.24.0. Please ensure that this version bump does not introduce breaking changes or require additional updates elsewhere in the codebase.

  • 88-88: A new dependency bsl-parser-core version 0.1.0 has been added. Please verify that it is integrated correctly and does not conflict with existing dependencies.

  • 74-91: > Note: This review was outside the patches, so it was mapped to the patch with the greatest overlap. Original lines [1-168]

Please perform a general check for any syntax errors, deprecated plugins, or configurations that might be affected by the updated dependencies.

Copy link

github-actions bot commented Jan 7, 2024

Qodana Community for JVM

17 new problems were found

Inspection name Severity Problems
Statement with empty body 🔶 Warning 5
'@Serial' annotation could be used 🔶 Warning 4
Constant values 🔶 Warning 3
Mismatched query and update of collection 🔶 Warning 2
Class is exposed outside of its visibility scope 🔶 Warning 1
Nullability and data flow problems 🔶 Warning 1
Mismatched read and write of array 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Copy link

sonarcloud bot commented Jan 7, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@theshadowco theshadowco merged commit 086aad3 into develop Jan 7, 2024
33 checks passed
@theshadowco theshadowco deleted the feature/bslparser024 branch January 7, 2024 06:35
@theshadowco theshadowco restored the feature/bslparser024 branch January 7, 2024 06:35
@theshadowco theshadowco deleted the feature/bslparser024 branch January 7, 2024 06:35
@nixel2007
Copy link
Member

@theshadowco ты мне расскажи, почему core не сделать как api в bsl-parser? Зачем его тащить в клиента?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants