Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes & bumps #3233

Merged
merged 3 commits into from
Jan 24, 2024

review fix

0d08d8c
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Fixes & bumps #3233

review fix
0d08d8c
Select commit
Loading
Failed to load commit list.
GitHub Actions / Qodana Community for JVM completed Jan 24, 2024 in 0s

16 new problems found by Qodana Community for JVM

Qodana Community for JVM

16 new problems were found

Inspection name Severity Problems
Statement with empty body 🔶 Warning 5
'@Serial' annotation could be used 🔶 Warning 4
Constant values 🔶 Warning 2
Mismatched query and update of collection 🔶 Warning 2
Class is exposed outside of its visibility scope 🔶 Warning 1
Nullability and data flow problems 🔶 Warning 1
Mismatched read and write of array 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Details

This result was published with Qodana GitHub Action

Annotations

Check warning on line 56 in src/main/java/com/github/_1c_syntax/bsl/languageserver/reporters/GenericIssueReport.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Class is exposed outside of its visibility scope

Class `GenericIssueEntry` is exposed outside its defined visibility scope

Check warning on line 202 in src/main/java/com/github/_1c_syntax/bsl/languageserver/diagnostics/CodeOutOfRegionDiagnostic.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Constant values

Method reference result is always 'false'

Check warning on line 201 in src/main/java/com/github/_1c_syntax/bsl/languageserver/diagnostics/CodeOutOfRegionDiagnostic.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Constant values

Result of `Optional.of(child).stream() .filter(BSLParser.StatementContext.class::isInstance) .map(B...` is always 'false'

Check warning on line 122 in src/main/java/com/github/_1c_syntax/bsl/languageserver/diagnostics/RefOveruseDiagnostic.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Nullability and data flow problems

Method invocation `getRuleIndex` may produce `NullPointerException`

Check warning on line 265 in src/main/java/com/github/_1c_syntax/bsl/languageserver/context/symbol/description/DescriptionReader.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Statement with empty body

`else` statement has empty body

Check warning on line 124 in src/main/java/com/github/_1c_syntax/bsl/languageserver/context/symbol/description/DescriptionReader.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Statement with empty body

`else` statement has empty body

Check warning on line 374 in src/main/java/com/github/_1c_syntax/bsl/languageserver/context/symbol/description/DescriptionReader.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Statement with empty body

`else` statement has empty body

Check warning on line 158 in src/main/java/com/github/_1c_syntax/bsl/languageserver/diagnostics/NestedFunctionInParametersDiagnostic.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Statement with empty body

`else` statement has empty body

Check warning on line 279 in src/main/java/com/github/_1c_syntax/bsl/languageserver/providers/FormatProvider.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Statement with empty body

`else` statement has empty body

Check warning on line 133 in src/main/java/com/github/_1c_syntax/bsl/languageserver/cli/AnalyzeCommand.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Mismatched read and write of array

Contents of array `reportersOptions` are read, but never written to

Check warning on line 40 in src/main/java/com/github/_1c_syntax/bsl/languageserver/reporters/ReportersAggregator.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Mismatched query and update of collection

Contents of collection `reporters` are queried, but never updated

Check warning on line 46 in src/main/java/com/github/_1c_syntax/bsl/languageserver/reporters/ReportersAggregator.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Mismatched query and update of collection

Contents of collection `filteredReporters` are queried, but never updated

Check warning on line 34 in src/main/java/com/github/_1c_syntax/bsl/languageserver/configuration/events/LanguageServerConfigurationChangedEvent.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

'@Serial' annotation could be used

`serialVersionUID` can be annotated with '@Serial' annotation

Check warning on line 29 in src/main/java/com/github/_1c_syntax/bsl/languageserver/context/events/DocumentContextContentChangedEvent.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

'@Serial' annotation could be used

`serialVersionUID` can be annotated with '@Serial' annotation

Check warning on line 29 in src/main/java/com/github/_1c_syntax/bsl/languageserver/context/events/ServerContextPopulatedEvent.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

'@Serial' annotation could be used

`serialVersionUID` can be annotated with '@Serial' annotation

Check warning on line 36 in src/main/java/com/github/_1c_syntax/bsl/languageserver/events/LanguageServerInitializeRequestReceivedEvent.java

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

'@Serial' annotation could be used

`serialVersionUID` can be annotated with '@Serial' annotation