Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gradle Wrapper from 8.1.1 to 8.6 #3241

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Feb 12, 2024

Update Gradle Wrapper from 8.1.1 to 8.6.

Read the release notes: https://docs.gradle.org/8.6/release-notes.html


The checksums of the Wrapper JAR and the distribution binary have been successfully verified.

  • Gradle release: 8.6
  • Distribution (-bin) zip checksum: 9631d53cf3e74bfa726893aee1f8994fee4e060c401335946dba2156f440f24c
  • Wrapper JAR Checksum: d3b261c2820e9e3d8d639ed084900f11f4a86050a8f83342ade7b6bc9b0d2bdd

You can find the reference checksum values at https://gradle.org/release-checksums/


🤖 This PR has been created by the Update Gradle Wrapper action.

Need help? 🤔

If something doesn't look right with this PR please file an issue here.

Summary by CodeRabbit

  • Обновления
    • Обновлена версия Gradle с 8.1.1 до 8.6, добавлено новое свойство validateDistributionUrl.
  • Исправления
    • Изменено поведение скрипта gradlew для улучшения обработки переменной APP_HOME, обновлена логика по умолчанию для DEFAULT_JVM_OPTS, улучшено обработка ошибок, связанных с доступностью команды java и запросом/установкой лимита файловых дескрипторов.
    • В скрипте gradlew.bat обновлены сообщения об ошибках для вывода в stderr и добавлено перенаправление 1>&2 в командах echo для обработки ошибок.

Signed-off-by: gradle-update-robot <gradle-update-robot@regolo.cc>
@github-actions github-actions bot added the gradle-wrapper Pull requests that update Gradle wrapper label Feb 12, 2024
Copy link

coderabbitai bot commented Feb 12, 2024

Обзор изменений

Обновления включают повышение версии Gradle, улучшение скриптов сборки для Unix и Windows, добавление новых настроек безопасности и оптимизацию обработки ошибок. Эти изменения направлены на повышение производительности, улучшение удобства использования и обеспечение безопасности.

Изменения

Файлы Описание изменений
gradle/.../gradle-wrapper.properties Обновление версии Gradle с 8.1.1 до 8.6, добавление свойства validateDistributionUrl.
gradlew, gradlew.bat Обновление логики обработки APP_HOME, настройки DEFAULT_JVM_OPTS, улучшение обработки ошибок и вывода сообщений об ошибках.

🐇✨
Код меняется, как весенний ручей,
Версии Gradle растут, не останавливаясь.
Скрипты теперь строги, как зимний мороз,
Ошибки уйдут, словно тени в ночи.
Пусть этот релиз будет легким, как воздух!
🌟🐰

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@nixel2007
Copy link
Member

@coderabbitai review

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 0ffc35f and f1c6ff8.
Files ignored due to path filters (1)
  • gradle/wrapper/gradle-wrapper.jar is excluded by: !**/*.jar
Files selected for processing (3)
  • gradle/wrapper/gradle-wrapper.properties (1 hunks)
  • gradlew (3 hunks)
  • gradlew.bat (2 hunks)
Additional comments: 8
gradle/wrapper/gradle-wrapper.properties (2)
  • 3-3: Изменен URL дистрибутива Gradle на версию 8.6. Убедитесь, что это соответствует целям обновления.
  • 5-5: Добавлено свойство validateDistributionUrl=true. Это улучшение безопасности, подтверждающее использование проверенного URL дистрибутива.
gradlew.bat (2)
  • 46-50: Добавлен вывод ошибок в stderr для сообщения об отсутствии переменной окружения JAVA_HOME или команды java в PATH. Это улучшение удобства использования.
  • 60-64: Добавлен вывод ошибок в stderr для сообщения о неверно установленной переменной JAVA_HOME. Это улучшение удобства использования.
gradlew (4)
  • 86-87: Изменение в обработке APP_HOME с подавлением вывода команды cd улучшает совместимость и предотвращает потенциальные проблемы из-за переменной CDPATH.
  • 134-140: Улучшена обработка ошибок при отсутствии команды java в PATH. Это улучшение надежности скрипта.
  • 148-156: Изменения в обработке лимита файловых дескрипторов улучшают совместимость и производительность на не-Windows платформах.
  • 202-204: Добавлены значения по умолчанию для DEFAULT_JVM_OPTS. Убедитесь, что они соответствуют требованиям проекта.

@nixel2007 nixel2007 closed this Feb 13, 2024
@nixel2007 nixel2007 reopened this Feb 13, 2024
@ghost
Copy link

ghost commented Feb 13, 2024

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link
Author

Qodana Community for JVM

14 new problems were found

Inspection name Severity Problems
Statement with empty body 🔶 Warning 5
'@Serial' annotation could be used 🔶 Warning 4
Mismatched query and update of collection 🔶 Warning 2
Class is exposed outside of its visibility scope 🔶 Warning 1
Nullability and data flow problems 🔶 Warning 1
Mismatched read and write of array 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Copy link

sonarcloud bot commented Feb 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@nixel2007 nixel2007 merged commit 99f1164 into develop Feb 13, 2024
21 checks passed
@nixel2007 nixel2007 deleted the gradlew-update-8.6 branch February 13, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gradle-wrapper Pull requests that update Gradle wrapper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants