Исправлена ошибка разбор условия препроцессора #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
с отрицанием вложенного условия
nixel2007
reviewed
Nov 21, 2022
| @@ -49,9 +49,10 @@ preproc_expression | |||
| | preproc_logicalExpression | |||
| ; | |||
| preproc_logicalOperand | |||
| : (PREPROC_LPAREN PREPROC_NOT_KEYWORD? preproc_logicalOperand PREPROC_RPAREN) | |||
| : (PREPROC_NOT_KEYWORD? PREPROC_LPAREN preproc_logicalOperand PREPROC_RPAREN) | |||
There was a problem hiding this comment.
Мне не очень нравится вынос NOT за скобки. Может случиться неоднозначный парсинг. В старой схеме NOT стоит либо внутри скобок перед рекурсивным логическим операндом, либо перед символом препроцессора. Если оставить на первой строке старый вариант, но добавить на 54 строку необязательный NOT после LPAREN, не решится эта же проблема?
There was a problem hiding this comment.
Проверю, но скорее всего вообще такой вариант не используется. Раз до этого не поймали.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Исправлена ошибка разбор условия препроцессора с отрицанием вложенного условия
Подобная инструкция препроцессора ломала разбор