Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI-328] Pin Ubuntu version for GitHub Actions workflows #4

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

maciej-chime
Copy link
Contributor

@maciej-chime maciej-chime commented Nov 27, 2024

GitHub is updating the version of Ubuntu used by the ubuntu-latest tag, including removing some packages. What's worse is that we don't have an exact date, but it's supposed to happen sometime between Dec 5 and Jan 17.

This could potentially result in difficult to predict failures to workflows, especially difficult to test if they run only on the main branch and not as part of pull requests on feature branches.

To prevent that from happening, we want to get ahead of that update and upgrade the version to 24.04 right now for all "standard" GitHub workflows, incl.:

  • Mergebot (check-can-merge.yml) - additional changes in this file may be present to align it with the latest template version
  • Dependabot auto-approve (dependabot-auto-approve.yml) - additional changes in this file may be present to align it with the latest template version
  • Stale PR checks (stale.yml or pr-cleanup.yml)

For all other workflows, the change locks in the version to 22.04 (which is what ubuntu-latest is set to right now) so teams can individually update them to 24.04, verifying that everything continues to work as expected.

Please make sure to create tickets in your backlog to schedule that work in before EOQ1 2025.

Note that we no longer recommend using the floating ubuntu-latest tag going forward.

Created by Sourcegraph batch change maciej-chime/GithubWorkflowsPinUbuntuVersion.

@maciej-chime maciej-chime force-pushed the mm-gh-workflows-pin-ubuntu-version branch from 1de2b03 to 51ee32f Compare December 2, 2024 16:25
@maciej-chime maciej-chime marked this pull request as ready for review December 2, 2024 21:48
@maciej-chime maciej-chime requested review from rlisagor and a team December 2, 2024 21:49
@maciej-chime maciej-chime merged commit 8ee7175 into main Dec 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants