Vehicle group fixes #207
Merged
Vehicle group fixes #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… movement plot issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CheckSquadMovementGroups called after load was forcing vehicles to use ubGroupID from Squad instead of correct ubMovementGroup from pVehicleList.
Issue: #91
There was another semi-related error with using VEHICLE assignment directly as a squad index causing out of range issue when plotting vehicle movement on the map screen.
It was also possible to duplicate squad assignments when unassigning mercs from a vehicle by unselecting them before movement in the movement plot flow due to automatic squad assignments putting them in the same squad they were supposed to be removed from.