avoid static initialization order fiasco in soundman.cpp #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when running the cmake Debug build instead of the ja2_vs2019.sln file s_SoundLog is undefined. the most likely reason for that is that static objects in global scope have unspecified initialization order. the problem is fixed if the static SoundLog object is created inside the SoundLog(CHAR8*) function instead. also remove the comment whose meaning apparently has been lost to the sands of time
CptMoore
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the CMake Debug build instead of
ja2_vs2019.sln,s_SoundLogis undefined insideSoundLog(CHAR8*). The most likely reason for that is that static objects in global scope have unspecified initialization order. The problem is fixed if the static SoundLog object is created inside the SoundLog(CHAR8*) function instead so thats_SoundLog's lifetime becomes defined.Also removed the comment whose meaning apparently has been lost to the sands of time.