Refactor ConstraintsLib and InputLib plus added new flags #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 0.00% // Head: 0.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #204 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 18 19 +1
Lines 420 418 -2
Branches 104 104
======================================
+ Misses 420 418 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
contracts/OrderRFQLib.sol
Outdated
| @@ -5,12 +5,32 @@ pragma solidity 0.8.17; | |||
| import "@1inch/solidity-utils/contracts/libraries/ECDSA.sol"; | |||
| import "@1inch/solidity-utils/contracts/libraries/AddressLib.sol"; | |||
|
|
|||
| type TraitsRFQ is uint256; | |||
|
|
|||
| library TraitsRFQLib { | |||
There was a problem hiding this comment.
Why "Traits" instead of "Details"?
k06a
force-pushed
the
feature/rfq-no-partial-fills
branch
from
e29b34a to
97ae79d
Compare
k06a
force-pushed
the
feature/rfq-no-partial-fills
branch
from
97ae79d to
827a0fb
Compare
k06a
force-pushed
the
feature/rfq-no-partial-fills
branch
from
b9f8c36 to
6b0b779
Compare
k06a
force-pushed
the
feature/rfq-no-partial-fills
branch
from
a280b0b to
d896752
Compare
| // proceed only if taker is willing to execute permit and its length is enough to store address | ||
| address token = address(bytes20(permit)); | ||
| bytes calldata permitCalldata = permit[20:]; | ||
| IERC20(token).safePermit(permitCalldata); // TODO: inline both arguments |
There was a problem hiding this comment.
Can be refactored simultaneously in multiple places
k06a
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
=>