Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SC-1165] Community resolvers logic #162

Merged
merged 11 commits into from
Jun 24, 2024
Merged

Conversation

zZoMROT
Copy link
Contributor

@zZoMROT zZoMROT commented Jun 18, 2024

Concerning gasUsed in postInteraction calldata using for backward compatibility:

# use resolverFeeEnabled() 2 times
| ResolverMock · settleOrders    · 122098 · 132917 · 125704 │
| Settlement   · postInteraction ·  28203 ·  32541 ·  31448 │

# use bool feeEnabled variable inside unchecked block
| ResolverMock · settleOrders    · 122073 · 132725 · 125624 │
| Settlement   · postInteraction ·  28160 ·  32355 ·  31298 │

# use bool feeEnabled variable outside unchecked block
| ResolverMock · settleOrders    · 122070 · 132710 · 125617 │
| Settlement   · postInteraction ·  28151 ·  32358 ·  31298 │

# use extraDataShift variable instead of cut extraData after feeEnabled check
| ResolverMock · settleOrders    · 122241 · 132948 · 125810 │
| Settlement   · postInteraction ·  28345 ·  32558 ·  31496 │

So, the best way is use bool feeEnabled variable outside unchecked block.

package.json Outdated Show resolved Hide resolved
zZoMROT and others added 2 commits June 24, 2024 11:11
Co-authored-by: Mikhail Melnik <by.zumzoom@gmail.com>
Co-authored-by: Mikhail Melnik <by.zumzoom@gmail.com>
@zZoMROT zZoMROT merged commit 9bf3ba1 into master Jun 24, 2024
5 checks passed
@zZoMROT zZoMROT deleted the feature/custom-resolver-support branch June 24, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants