Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SC-1242] skipIfAlreadyDeployed in deploy method via create3 #152

Merged
merged 3 commits into from
Aug 21, 2024

Conversation

zZoMROT
Copy link
Contributor

@zZoMROT zZoMROT commented Aug 15, 2024

Static Code Analysis (readability, compactness):

It's good enough readable and compact check.

Dynamic Code Analysis (external APIs, interaction flows):

By default the check is switched on to protect developer from prevent unnecessary redeployment of already deployed contracts. Allows to customize this setting status as needed.

Efficiency (gas costs, computational complexity, memory requirements):

No impact on gas costs and computational complexity.

Opinion, trade-offs and other thoughts (optional):

This addition is a straightforward and effective way to enhance deployment logic, with minimal trade-offs. It ensures that resources are used more efficiently without adding significant complexity to the codebase.

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.33%. Comparing base (1bb2620) to head (3d02e71).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #152   +/-   ##
=======================================
  Coverage   93.33%   93.33%           
=======================================
  Files          17       17           
  Lines         345      345           
  Branches       67       67           
=======================================
  Hits          322      322           
  Misses         23       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zZoMROT zZoMROT merged commit 98f381f into master Aug 21, 2024
8 checks passed
@zZoMROT zZoMROT deleted the feature/patch-deploy-create3 branch August 21, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants