Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SC-1394] Fix avax forking issue #171

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Conversation

zZoMROT
Copy link
Contributor

@zZoMROT zZoMROT commented Jan 21, 2025

Added a temporary solution by manually specifying the hardforkHistory property in Hardhat configuration to fix forking issue for Avalanche networks (the same as NomicFoundation/hardhat#5511) until a fix is implemented in Hardhat.

Static Code Analysis (readability, compactness):

  • The solution is straightforward and does not introduce significant complexity.
  • The added configuration is clear and maintains code readability.

Dynamic Code Analysis (external APIs, interaction flows):

Efficiency (gas costs, computational complexity, memory requirements):

  • No additional computational overhead introduced, as the changes only affect configuration.
  • The impact is limited to the forking environment, with no runtime performance issues.

Opinion, trade-offs and other thoughts (optional):

  • This is a temporary workaround until Hardhat provides an official solution.
  • If incorrect block numbers were used, feedback and corrections are welcome.

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (5085b30) to head (1a31651).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #171   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines          342       342           
  Branches        65        65           
=========================================
  Hits           342       342           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zZoMROT zZoMROT force-pushed the feature/avax-hardfork-history branch from 3d72180 to 1a31651 Compare January 21, 2025 23:46
@galekseev galekseev merged commit 0268e85 into master Jan 22, 2025
8 checks passed
@galekseev galekseev deleted the feature/avax-hardfork-history branch January 22, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants