Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron packaging (start creating desktop app releases) #48

Open
1j01 opened this issue Apr 13, 2024 · 1 comment
Open

Electron packaging (start creating desktop app releases) #48

1j01 opened this issue Apr 13, 2024 · 1 comment
Labels
affects:desktop-app Affects the Electron app enhancement New feature or request

Comments

@1j01
Copy link
Owner

1j01 commented Apr 13, 2024

I want to start producing builds early. I can copy a lot of boilerplate/configuration from jspaint.

Electron and Electron Forge both pretend to be way simpler than they are in practice, but what are you gonna do?

@1j01 1j01 added enhancement New feature or request affects:desktop-app Affects the Electron app labels Apr 13, 2024
@1j01 1j01 mentioned this issue Apr 13, 2024
@1j01
Copy link
Owner Author

1j01 commented Apr 18, 2024

  • Fix the build Can't build electron app due to dependency on parent folder #53
  • Fix icons in packaged app. I tried a symlink, but Electron Forge broke. I could make the images folder into an internal "resources" npm package, or I could just copy the needed icons into the app. I don't expect to change them frequently, and it would be nice to have a clean separation of what is required by the app, in order to limit the size of the app.
  • Handle Squirrel events properly. Don't require serenade-driver or anything until after exit for installer, since if it errors, it's pretty ugly, and may even leave the installer process running. Exit properly. app.quit() doesn't exit immediately!
  • Prevent click at startup — especially since the non-traditional Windows installer installs and runs the app in one click! —through some combination of:
  • Establish some sort of release process
  • I should make sure the npm package has a README. I've moved it into a folder, so the README is no longer next to the package.json file. Maybe the API.md can become the readme of the library?

@1j01 1j01 mentioned this issue Oct 14, 2024
3 tasks
1j01 added a commit that referenced this issue Oct 16, 2024
1j01 added a commit that referenced this issue Oct 16, 2024
Getting ready for a release...
#48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects:desktop-app Affects the Electron app enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant