Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small grammar and formatting check #14

Merged
merged 1 commit into from
May 17, 2024
Merged

small grammar and formatting check #14

merged 1 commit into from
May 17, 2024

Conversation

faroit
Copy link

@faroit faroit commented May 16, 2024

Hi @1oly here are a few small suggestions wrt to grammar and formatting (mainly the julia code example) as part of my openjournals/joss-reviews#6390 editing

Feel free to merge as you like.

Regarding the two references without DOI - for this one:

Glegg, S., & Devenport, W. (2017). Aeroacoustics of low mach number flows: Fundamentals, analysis, and measurement (pp. 1–537). Academic Press, Elsevier. ISBN: 9780128097939 Johnson,

would https://doi.org/10.1016/C2022-0-00864-3 work here?

D. H. D. H., & Dudgeon, D. E. (1993). Array signal processing: Concepts and techniques. In Book (p. 533). Englewood Cliffs: PTR Prentice Hall. ISBN: 9780130485137

i didn't find anything for this either, so thats fine

@1oly 1oly merged commit b3f1d7f into 1oly:paper May 17, 2024
8 checks passed
@1oly
Copy link
Owner

1oly commented May 17, 2024

Hi @faroit Thanks, looks better now :) Regarding the DOI. Yes, it is the new edition of the same book, but I haven't actually read it, so can't be sure it still fits. Would prefer to keep the old one, if that's okay.

@faroit
Copy link
Author

faroit commented May 17, 2024

Yeah. I guessed so. So let's keep it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants