Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split the code into a library and binary to enable toolbx integration #10

Open
travier opened this issue Aug 8, 2022 · 3 comments
Open

Split the code into a library and binary to enable toolbx integration #10

travier opened this issue Aug 8, 2022 · 3 comments

Comments

@travier
Copy link
Contributor

travier commented Aug 8, 2022

One option to add this directly into toolbx upstream is to split the logic into a library that is pulled by toolbx and kept here for this binary.
@1player
Copy link
Owner

1player commented Aug 9, 2022 •
edited
Loading

Where would this "split" be? I reckon you'd want the whole of runCommandSync into the library, is that correct?

host-spawn/main.go

Line 160 in 6fb65d0

exitCode, err := runCommandSync(command, allocatePty)

@travier
Copy link
Contributor Author

travier commented Aug 9, 2022

I'm not really sure. We might need to ask toolbx maintainers if and how they want to do it.

1player added a commit that referenced this issue Oct 12, 2022
@1player
Clarify that by default we only pass through the TERM variable
ddefc3c 
Also, refactor the environment variable logic to keep the core function
`runCommandSync` as freestanding as possible, in preparation for #10
@1player
Copy link
Owner

1player commented Apr 26, 2023

Are the toolbx maintainers still interested in integrating this?

@1player 1player mentioned this issue Sep 12, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@1player @travier