-
Notifications
You must be signed in to change notification settings - Fork 809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ZgatewaySERIAL.ino Fix tx issues #2131
base: development
Are you sure you want to change the base?
Conversation
Do you have |
It is not mentioned in the header file, so I initially thought it was still under construction. I recommend updating and commenting on it in the header file. Otherwise, many users may struggle to understand and utilize the tx function effectively. |
We could condition |
Sounds great |
@mycprotein would you like to update the PR to do this ? |
3f9ad44
to
9050203
Compare
The serial gateway can only receive serial data and publish via mqtt, but can not convert mqtt into serial data. It is because the receiverReady is not handled correctly for the tx part. A quick work around is to set receiverReady to true. (it seems not used)
bd00cf3
to
1618ded
Compare
not sure if it will work |
Why do you think so ? |
I'm not a C++ programmer, so I'm not entirely sure if my modification is correct. However, it seems right to me. If it makes sense to you, then it should be fine. |
The serial gateway can only receive serial data and publish via mqtt, but can not convert mqtt into serial data. It is because the receiverReady is not handled correctly for the tx part. A quick work around is to set receiverReady to true. (it seems not used)
Description:
Checklist: