Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#400: add typescript #402

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

kvaithin
Copy link

Issue: #400


PR Checklist
  • [X ] Give this PR a meaningful title
  • [ X] Add a link to the related issue at the top of this description (above)
  • Connect this PR with the related issue via ZenHub with the button below this text box (or at the bottom of the page after the PR is created)
  • [X ] Ensure your branch is up to date with the target branch and resolve any conflicts
  • [X ] Answer the below questions to describe your PR for reviewers
  • Request at least two reviewers using the "Reviewers" section on the right, usually including at least one reviewer from your team
  • Notify the requested reviewers in the #code-review Slack channel once the PR is ready for review

Why are these changes needed?

Adding typescript to project.

What changed?

Updated dependencies to support typescript across lint and storybook and component.

How are these changes tested?

Validated via npm test and storybook.

@kvaithin
Copy link
Author

Hi @jocelynn1uphealth, don 't see the Zenhub button mentioned in the description
I'm also not part of this #code-review Slack channel. Pls do advice how I could get this work reviewed / merged. Thank.

@kvaithin
Copy link
Author

kvaithin commented Apr 1, 2023

Hi @jocelynn1uphealth pls advice if I am missing any pre requisites to getting this reviewed. Thanks. :)

Copy link
Contributor

@jocelynn1uphealth jocelynn1uphealth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment about some extraneous comments in the tsconfig.json file, also ran into an issue when trying to build (screenshot below)

Screen Shot 2023-04-05 at 10 14 14 AM

@@ -0,0 +1,111 @@
{
"compilerOptions": {
/* Visit https://aka.ms/tsconfig to read more about this file */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove all these extraneous comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants