-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark mode chart #21
Comments
Hi there, I have looked through the GitHub site to find the colors used with their dark theme (if you're into that). I have never used ruby before, so I may or may not open a PR. Feel free to scoop this change if you'd like. The hex color codes are as follows:
I believe these should be added here, as a new Lines 1 to 5 in 2a12825
i.e. dark: ['#161b22', "#1e6823", "#034525", "#0f6d31", "#00c647"]
It's not obvious to me where the background color of the SVG gets set, but that should be Hope this helps! |
Hi Eric,
Also not experienced with Ruby but will tinker with it and see what I can
do. Thanks for your help
…On Sun, 10 Jan 2021, 23:42 Eric Graves, ***@***.***> wrote:
Hi there, I have looked through the GitHub site to find the colors used
with their dark theme (if you're into that). I have never used ruby before,
so I may or may not open a PR. Feel free to scoop this change if you'd like.
The hex color codes are as follows:
#161b22 -- color-calendar-graph-day-border (no contributions)
#1e6823 -- L1 bg
#034525 -- L2 bg
#0f6d31 -- L3 bg
#00c647 -- L4 bg (most contributions)
#0d1117 -- site background in dark mode
I believe these should be added here, as a new dark scheme:
https://github.com/2016rshah/githubchart-api/blob/2a12825b20e92f534ef5628784b2777a7ff2890c/color.rb#L1-L5
i.e. dark: ['#161b22', "#1e6823", "#034525", "#0f6d31", "#00c647"]
It's not obvious to me where the background color of the SVG gets set, but
that should be #0d1117.
Hope this helps!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#21 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANPM4IKPUF2Q6TY6FF5HMDLSZIUMDANCNFSM4UV5VSAA>
.
|
Anyone working on this? |
Oh no I dropped it, got very busy with work
…On Wed, 31 Mar 2021, 14:45 Aryan Khandelwal, ***@***.***> wrote:
Anyone working on this?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#21 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANPM4IISAK6QYRXNKYIFOGLTGMRQFANCNFSM4UV5VSAA>
.
|
Would be cool! I'm not actively developing this project but I'll add a feature request label in case anybody wants to take a stab at it in the future! |
Can we have a dark mode chart since github updated their site to dark mode?
The text was updated successfully, but these errors were encountered: