Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode chart #21

Open
devTam opened this issue Dec 11, 2020 · 5 comments
Open

Dark mode chart #21

devTam opened this issue Dec 11, 2020 · 5 comments

Comments

@devTam
Copy link

devTam commented Dec 11, 2020

Can we have a dark mode chart since github updated their site to dark mode?

@eridgraves
Copy link

Hi there, I have looked through the GitHub site to find the colors used with their dark theme (if you're into that). I have never used ruby before, so I may or may not open a PR. Feel free to scoop this change if you'd like.

The hex color codes are as follows:

#161b22 -- color-calendar-graph-day-border (no contributions)
#1e6823 -- L1 bg
#034525 -- L2 bg
#0f6d31 -- L3 bg
#00c647 -- L4 bg (most contributions)
#0d1117 -- site background in dark mode

I believe these should be added here, as a new dark scheme:

COLOR_SCHEMES = {
default: ['#eeeeee', '#d6e685', '#8cc665', '#44a340', '#1e6823'],
halloween: ['#EEEEEE', '#FFEE4A', '#FFC501', '#FE9600', '#03001C'],
teal: ['#EEEEEE', "#7FFFD4", "#76EEC6", "#66CDAA", "#458B74"]
}

i.e. dark: ['#161b22', "#1e6823", "#034525", "#0f6d31", "#00c647"]

It's not obvious to me where the background color of the SVG gets set, but that should be #0d1117.

Hope this helps!

@devTam
Copy link
Author

devTam commented Jan 11, 2021 via email

@aryan29
Copy link

aryan29 commented Mar 31, 2021

Anyone working on this?

@devTam
Copy link
Author

devTam commented Apr 2, 2021 via email

@2016rshah
Copy link
Owner

Would be cool! I'm not actively developing this project but I'll add a feature request label in case anybody wants to take a stab at it in the future!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants