Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAPHY-70 feat: 기기 등록 기능 (관리자) #88

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

gyuseon25
Copy link
Member

📄 Summary

관리자일시에만 기기등록 가능하도록 수정했습니다.
docker-compose 파일 쉘 스크립트 통해 redis 실행 되도록 수정했습니다.

🕰️ Actual Time of Completion

1시간

🙋🏻 More

@gyuseon25 gyuseon25 added the ♻️ Refactor 코드 리팩토링 label Oct 2, 2024
@gyuseon25 gyuseon25 self-assigned this Oct 2, 2024
Copy link
Member

@MinSang22Kim MinSang22Kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~!

Comment on lines +29 to +30
sh -c "redis-server --requirepass ${REDIS_PASSWORD} --port ${REDIS_PORT:-6379}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

쉘을 통해 실행하는 명령어로 변경하셨군요!! 더 유연한 방식이라서 좋은 거 같습니당

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오오 찾아봐야겠습니다

@MinSang22Kim MinSang22Kim merged commit 5a3b54a into develop Oct 2, 2024
1 check passed
Copy link
Contributor

@holyPigeon holyPigeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨ㅅㅂ니다~

Comment on lines +29 to +30
sh -c "redis-server --requirepass ${REDIS_PASSWORD} --port ${REDIS_PORT:-6379}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오오 찾아봐야겠습니다

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
♻️ Refactor 코드 리팩토링
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants