Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies to support Django 4.2 #27

Merged
merged 2 commits into from
May 22, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 1 addition & 14 deletions src/django_handleref/admin.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,12 @@
import traceback

from django import forms
from django.conf.urls import re_path
from django.contrib import admin
from django.contrib.admin.views.main import ChangeList
from django.core.exceptions import ValidationError
from django.shortcuts import redirect
from django.template.response import TemplateResponse
from django.urls import re_path
from django.utils.translation import gettext_lazy as _

# soft import reversion - since it is not a hard
Expand Down Expand Up @@ -123,7 +123,6 @@ def history_query_set(self, object_id):
return history_qset

def history_entry(self, version, previous):

"""
Compile object history list entry dict

Expand Down Expand Up @@ -186,7 +185,6 @@ def history(self, history_qset):
return history

def history_view(self, request, object_id):

"""
object history view
"""
Expand Down Expand Up @@ -225,7 +223,6 @@ def history_view(self, request, object_id):
return super().history_view(request, object_id, context)

def version_details_view(self, request, object_id, version_id, extra_context=None):

"""
Show version details
"""
Expand All @@ -251,7 +248,6 @@ def version_details_view(self, request, object_id, version_id, extra_context=Non
return TemplateResponse(request, self.version_details_template, context)

def version_revert_view(self, request, object_id, extra_context=None):

"""
Show version revert preview / confiformation view
"""
Expand Down Expand Up @@ -286,7 +282,6 @@ def version_revert_view(self, request, object_id, extra_context=None):
return TemplateResponse(request, self.version_revert_template, context)

def version_revert_process(self, request, object_id, extra_context=None):

"""
Process revert version(s)
"""
Expand All @@ -312,21 +307,18 @@ def version_revert_process(self, request, object_id, extra_context=None):

errors = {}
try:

# revert

reverter = self.reverter_cls()
instance = self.model.objects.get(pk=object_id)
reverter.revert_fields(instance, field_versions, user=request.user)

except ValidationError as exc:

# validation errors are collected

errors = exc.message_dict

except Exception as exc:

# any other errors are logged

errors = {"non_field_errors": ["Internal Error (check server logs)"]}
Expand All @@ -352,7 +344,6 @@ def version_revert_process(self, request, object_id, extra_context=None):
)

def version_rollback_view(self, request, object_id, version_id, extra_context=None):

"""
Version rollback preview / confirmation view
"""
Expand All @@ -377,7 +368,6 @@ def version_rollback_view(self, request, object_id, version_id, extra_context=No
def version_rollback_process(
self, request, object_id, version_id, extra_context=None
):

"""
Version rollback process
"""
Expand All @@ -391,21 +381,18 @@ def version_rollback_process(

errors = {}
try:

# rollback

reverter = self.reverter_cls()
instance = self.model.objects.get(pk=object_id)
reverter.rollback(instance, version, user=request.user)

except ValidationError as exc:

# collect validation errors

errors = exc.message_dict

except Exception as exc:

# log any other errors

errors = {"non_field_errors": ["Internal Error (check server logs)"]}
Expand Down
4 changes: 0 additions & 4 deletions src/django_handleref/manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ def since(self, timestamp=None, version=None, deleted=False):
qset = self

if timestamp is not None:

if isinstance(timestamp, numbers.Real):
timestamp = datetime.datetime.fromtimestamp(timestamp)

Expand All @@ -56,17 +55,14 @@ def since(self, timestamp=None, version=None, deleted=False):
)

if version is not None:

qset = qset.filter(version__gt=version)

if not deleted:

qset = qset.undeleted()

return qset

def undeleted(self):

"""
Only return objects that are not soft-deleted
"""
Expand Down
1 change: 0 additions & 1 deletion src/django_handleref/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,6 @@ def __unicode__(self):
return name + "-" + self.handle

def delete(self, hard=False):

"""
Override the vanilla delete functionality to soft-delete
instead. Soft-delete is accomplished by setting the
Expand Down
10 changes: 0 additions & 10 deletions src/django_handleref/version.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ class Version:
"""

def __init__(self, version):

"""
Argument(s):

Expand Down Expand Up @@ -154,7 +153,6 @@ def changes(self, previous):
return Diff(previous, self).changes

def changed_fields(self, previous):

"""
Return a list of changed fields between
this version and a previous version
Expand Down Expand Up @@ -333,7 +331,6 @@ class Diff:
]

def __init__(self, version_a, version_b):

"""
Argument(s):

Expand All @@ -347,7 +344,6 @@ def __init__(self, version_a, version_b):

@property
def changes(self):

"""
Compile and return a dict describing changes between
the two versions tracked in this diff
Expand Down Expand Up @@ -409,7 +405,6 @@ class Reverter:
"""

def revert_fields(self, instance, field_versions, **kwargs):

"""
Revert a set of fields

Expand All @@ -434,7 +429,6 @@ def revert_fields(self, instance, field_versions, **kwargs):
instance.save()

def rollback(self, instance, version, **kwargs):

"""
Rollback to a specific version

Expand All @@ -460,7 +454,6 @@ def rollback(self, instance, version, **kwargs):
instance.save()

def validate_status_change(self, instance, status):

"""
Validate a status value change - this will make sure
an object cannot be undeleted if a parent relationship
Expand All @@ -484,7 +477,6 @@ def validate_status_change(self, instance, status):
self.validate_parent_status(instance, relation, status)

def validate_parent_status(self, instance, parent, status):

if not hasattr(parent, "HandleRef"):
return

Expand All @@ -505,7 +497,6 @@ class ReversionReverter(Reverter):
"""

def revert_fields(self, instance, field_versions, user=None):

"""
Revert a set of fields

Expand Down Expand Up @@ -540,7 +531,6 @@ def revert_fields(self, instance, field_versions, user=None):
super().revert_fields(instance, field_versions)

def rollback(self, instance, version, user=None):

"""
Rollback to a specific version

Expand Down
1 change: 0 additions & 1 deletion tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ def reversion_org_many():


def pytest_configure():

settings.configure(
ROOT_URLCONF="tests.urls",
SECRET_KEY="mPqac6DEtYxY-0Mu946UUpg-YDVmXWkYj6L4rIE15_A",
Expand Down
1 change: 0 additions & 1 deletion tests/test_manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ def test_last_change(self):
self.assertEqual(Org.handleref.last_change(), org.updated)

def test_since(self):

org = self.orgs[0]
t = time.time()

Expand Down
2 changes: 0 additions & 2 deletions tests/test_version.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
],
)
def test_version_interface(field):

version = Version(object())

with pytest.raises(NotImplementedError):
Expand Down Expand Up @@ -103,7 +102,6 @@ def _test_rollback(org, versions, reverter):

@pytest.mark.django_db
def test_reversion_version_fields(db):

with reversion.create_revision():
org = VersionedOrg.objects.create(name="Test", status="ok")

Expand Down
2 changes: 1 addition & 1 deletion tests/urls.py
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
from django.conf import settings
from django.conf.urls import include, re_path
from django.conf.urls.static import static

# auto admin
from django.contrib import admin
from django.urls import re_path
from django.views.generic.base import RedirectView

admin.autodiscover()
Expand Down