Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zmq fixes #129

Merged
merged 2 commits into from
Aug 2, 2021
Merged

zmq fixes #129

merged 2 commits into from
Aug 2, 2021

Conversation

vegu
Copy link
Contributor

@vegu vegu commented Aug 2, 2021

fixes #126: zermoq plugin config validation wants both bind and connect to be set
fixes #128: module 'zmq.asyncio' has no attribute 'PUB'

vegu added 2 commits August 2, 2021 11:42
fixes #126: zermoq plugin config validation wants both bind and connect to be set
@codecov
Copy link

codecov bot commented Aug 2, 2021

Codecov Report

Merging #129 (cbfd050) into master (10b6cec) will increase coverage by 0.02%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #129      +/-   ##
==========================================
+ Coverage   69.81%   69.84%   +0.02%     
==========================================
  Files          17       17              
  Lines        1110     1111       +1     
==========================================
+ Hits          775      776       +1     
  Misses        335      335              
Impacted Files Coverage Δ
src/vaping/plugins/zeromq.py 68.88% <66.66%> (+0.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10b6cec...cbfd050. Read the comment docs.

@vegu vegu merged commit 87824a4 into master Aug 2, 2021
@grizz grizz deleted the zmq_fixes branch August 29, 2023 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant