Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cfg imports #37

Merged
merged 10 commits into from
Aug 9, 2023
Merged

Remove cfg imports #37

merged 10 commits into from
Aug 9, 2023

Conversation

daviddemeij
Copy link
Member

@daviddemeij daviddemeij commented Aug 8, 2023 •
edited
Loading

Found some instances where the imported configuration was still overwriting parameters.

tonzowonzo
tonzowonzo approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@tonzowonzo tonzowonzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think that benchmark results have returned to near-normal proves this fixes it too

@daviddemeij daviddemeij merged commit e97ecc4 into master Aug 9, 2023
@daviddemeij daviddemeij deleted the remove_cfg_imports branch August 10, 2023 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonzowonzo tonzowonzo tonzowonzo approved these changes

@MaxLenormand MaxLenormand Awaiting requested review from MaxLenormand

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daviddemeij @tonzowonzo