Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement header component #15

Merged
merged 4 commits into from
Sep 22, 2017
Merged

implement header component #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0c3b6be
implement header component
Sep 20, 2017
0d89aa7
make header more configurable
Sep 20, 2017
d7174e3
remove yarn.lock from .gitignore
Sep 22, 2017
a31c3b3
pass only backgroundImageUrl instead of the whole style object
Sep 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .storybook/addons.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
import '@storybook/addon-knobs/register'
2 changes: 2 additions & 0 deletions .storybook/config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { h } from 'preact';
import { configure, addDecorator } from '@storybook/react';
import { withKnobs } from '@storybook/addon-knobs';

import { Layout } from '../src/components/Layout';

Expand All @@ -8,6 +9,7 @@ addDecorator(story => (
{ story() }
</Layout>
));
addDecorator(withKnobs);

function loadStories() {
require('./stories');
Expand Down
1 change: 1 addition & 0 deletions .storybook/preview-head.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/font-awesome/4.7.0/css/font-awesome.min.css" />
1 change: 1 addition & 0 deletions .storybook/stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
require('../src/components/Header/Header.story');
164 changes: 139 additions & 25 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,11 @@
},
"homepage": "https://github.com/21-23/cssqd-ui#readme",
"dependencies": {
"preact": "^8.2.5"
"preact": "^8.2.5",
"react-fontawesome": "^1.6.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not critical for now, but just curious: can we engage it with 21-23/_qd-ui#42 ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say addressing 21-23/_qd-ui#42 will require too much effort, so let's postpone it

},
"devDependencies": {
"@storybook/addon-knobs": "^3.2.8",
"@storybook/react": "^3.2.8",
"babel-core": "^6.26.0",
"babel-loader": "^7.1.2",
Expand Down
Binary file added src/assets/images/header-bg.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading