fixed the issue when validate a space path

2403905 · Jul 5, 2024 · f9c7bb4 · f9c7bb4
1 parent fdd92bd
commit f9c7bb4
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 5 deletions.
diff --git a/changelog/unreleased/fix-space-put.md b/changelog/unreleased/fix-space-put.md
@@ -0,0 +1,5 @@
+Bugfix: Validate a space path
+
+We've fixed the issue when validating a space path
+
+https://github.com/cs3org/reva/pull/4750
diff --git a/internal/http/services/owncloud/ocdav/put.go b/internal/http/services/owncloud/ocdav/put.go
@@ -411,11 +411,13 @@ func (s *svc) handleSpacesPut(w http.ResponseWriter, r *http.Request, spaceID st
 		return
 	}
 
-	if err := ValidateName(filename(ref.Path), s.nameValidators); err != nil {
-		w.WriteHeader(http.StatusBadRequest)
-		b, err := errors.Marshal(http.StatusBadRequest, err.Error(), "", "")
-		errors.HandleWebdavError(&sublog, w, b, err)
-		return
+	if r.URL.Path != "/" {
+		if err := ValidateName(filepath.Base(ref.Path), s.nameValidators); err != nil {
+			w.WriteHeader(http.StatusBadRequest)
+			b, err := errors.Marshal(http.StatusBadRequest, err.Error(), "", "")
+			errors.HandleWebdavError(&sublog, w, b, err)
+			return
+		}
 	}
 
 	s.handlePut(ctx, w, r, &ref, sublog)