Added rustyline support for arrow keys + more

[TheRustyPickle]

What was added

• Arrow up and down key to cycle history
• Additional support of the left and right arrow keys to control the cursor, CTRL + C, and more. Check at rustyline

Changed

• rustyline currently handles all input events instead of the previous stdin

Up for feedback

• Whether to remove unused functions spawn_stdinput_handler and read_input
• Change line_handling.rs or line_handler to something more concise?
• The working directory is being used to save rustyline history. Suggestion for a concrete fixed path?
• rustyline can potentially support autocompletion similar to a shell (still unsure how). Create another issue for it?

Related issues: #20 #142. Looking forward to hearing your thoughts, @24seconds! Also, let me know if I can improve the pr message in some way so you can understand more easily.

[24seconds]

wow thank you for the quick action! I will take a look later (Friday night ~ late night KST 🙇 )

[24seconds]

Sorry. Today was busy day. Let me review this until tomorrow mid afternoon 🙇

[24seconds]

[Update]
I was busy today also due to unexpected accident. Let me finish the review until weekend KST.

[24seconds]

Thank you for the work! I left some nit comments.

[24seconds]

• Whether to remove unused functions spawn_stdinput_handler and read_input
• Change line_handling.rs or line_handler to something more concise?
• The working directory is being used to save rustyline history. Suggestion for a concrete fixed path?
• rustyline can potentially support autocompletion similar to a shell (still unsure how). Create another issue for it?

1. Good. Let's remove it
2. I left comment about naming. In my opinion, it would be nice to include input keyword in naming.
3. I suggest in memory history. I also left comment. Please take a look.
4. Oh! yes! It would be nice to work in another issue if it is complicated. If the code is not that long - under 10 lines (?), then you can do it in this pr.

Thank you @TheRustyPickle

[TheRustyPickle]

Thank you, @24seconds. Just wanted to confirm this for point 1. If I remove read_input, I must also remove a test named test_read_command. I will be working on the rest of the points that were made.

[24seconds]

Thank you, @24seconds. Just wanted to confirm this for point 1. If I remove read_input, I must also remove a test named test_read_command. I will be working on the rest of the points that were made.

Yes, please remove. Btw, can we write a test case for newly introduced code @TheRustyPickle ?

[TheRustyPickle]

Yes, sure. Will work on this as well.

[TheRustyPickle]

Hello @24seconds, I couldn't figure out how to add tests for the rustyline code part. Also check the issue here about it. Hope the rest of the code is alright. Thanks for your time!

[24seconds]

Got it. Let me take a look today!

[24seconds]

LGTM! Thank you so much for the work! I enjoyed new feature. Thank you!

[24seconds]

Thank you @TheRustyPickle !! Because of your recent contributions rust-cli-pomodoro app has improved a lot!

[24seconds]

I will update pakcage version in cargo and write release note on Sunday

[TheRustyPickle]

Thank you for being so cooperative and understanding throughout the process, @24seconds! 🙏