Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Japanese language #400

Closed
wants to merge 1 commit into from
Closed

Add Japanese language #400

wants to merge 1 commit into from

Conversation

sf26311646
Copy link

No description provided.

@sf26311646 sf26311646 closed this Aug 1, 2024
@sf26311646 sf26311646 deleted the japanese branch August 1, 2024 07:53
@sf26311646 sf26311646 restored the japanese branch August 1, 2024 08:01
@sf26311646 sf26311646 deleted the japanese branch August 1, 2024 08:02
@sf26311646 sf26311646 changed the title test w Aug 1, 2024
@25huizengek1
Copy link
Owner

@shun4277 What are you doing?

@sf26311646
Copy link
Author

I made a mistake.
sorry.
Could you delete this pull request?

@25huizengek1
Copy link
Owner

I can't, you'll have to ask GitHub support for that. What were you trying to do? Maybe I can help.

@sf26311646
Copy link
Author

I'm Japanese student.
I like your software.
So, I want to translate your software Japanese

@sf26311646
Copy link
Author

But, I didn't know how to use git.
Therefore, I made a mistake.

@sf26311646
Copy link
Author

Could you please tell me how to add a japanese?

@25huizengek1
Copy link
Owner

Step 1: download this file

image

Step 2: go into a random text editor and go translate! Replace the English values with Japanese translations until you've translated all entries.
FYI: the format strings should be translated as well. For example: format_time_left appears in the app as "(insert time here) left", so you only have to translate the part that is in English, and ignore the %1$d %1$s placeholders. These get replaced with the actual data.

image

FYI: only translate the part between the > and the <, for example (the highlighted part should be translated)

image

Step 3: save the result and upload it in this ticket, or create a pull request with this new file. In that case, place the newly created file inside of app/src/main/res/values-ja/strings.xml. After that, Japanese will be available in the next version of ViTune!

@sf26311646
Copy link
Author

Thank you!
I'll try it!

@sf26311646
Copy link
Author

Japanese translation has been completed.
Source code to add Japanese.
values-ja.zip

But, there were some parts that were not reflected in the translation.
Please check the attached image.
Screenshot_20240802-011100
Screenshot_20240802-011121

@25huizengek1 25huizengek1 changed the title w Add Japanese language Aug 1, 2024
@25huizengek1
Copy link
Owner

ViTune gets those strings from YouTube Music, so unfortunately there's nothing I can do about that.

25huizengek1 pushed a commit that referenced this pull request Aug 1, 2024
@25huizengek1
Copy link
Owner

@sf26311646 Merged into master, thank you so much for your contribution.

epicX67 pushed a commit to epicX67/ViTune that referenced this pull request Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants